Merge pull request #5660 from JohnONolan/zelda-audit

Zelda audit

core/client/app/styles/components/dropdowns.css

@@ -22,7 +22,7 @@
     background-color: #fff;
     background-clip: padding-box;
     border-radius: 4px;
-    box-shadow: rgba(0, 0, 0, 0.175) 0 2px 6px;
+    box-shadow: rgba(0, 0, 0, 0.10) 0 2px 6px;
     list-style: none;
     text-align: left;
     text-transform: none;

core/client/app/styles/components/notifications.css

@@ -128,13 +128,13 @@
     font-size: 1.4rem;
     line-height: 1.3em;
     font-weight: 200;
-    user-select: all;
+    user-select: text;
 }
 
 .gh-alert a {
     text-decoration: underline;
     font-weight: 400;
-    user-select: all;
+    user-select: text;
 }
 
 .gh-alert-close {

core/client/app/styles/layouts/content.css

@@ -216,11 +216,12 @@
 
 .content-preview .post-controls {
     position: absolute;
-    top: 25px;
+    top: 5px;
     right: 25px;
 }
 
-.content-preview .post-controls .btn {
+.content-preview .post-controls .post-edit {
+    padding-top: 0;
     padding-right: 0;
     border: none;
     font-size: 18px;

core/client/app/styles/layouts/editor.css

@@ -156,7 +156,7 @@
 
 .entry-preview-content *,
 .content-preview-content * {
-    user-select: all;
+    user-select: text;
 }
 
 .entry-preview-content a,

core/client/app/styles/layouts/main.css

@@ -192,7 +192,7 @@
 .gh-nav-footer-sitelink {
     flex-grow: 1;
     padding: 12px;
-    color: var(--midgrey);
+    color: color(var(--midgrey) lightness(-10%));
     text-align: center;
     text-transform: uppercase;
     font-size: 1rem;
@@ -327,13 +327,12 @@
 .gh-help-menu {
     display: flex;
     align-items: center;
-    padding: 5px 10px;
     border-left: #dfe1e3 1px solid;
     cursor: pointer;
 }
 
 .gh-help-button {
-    padding: 0 5px;
+    padding: 5px 15px;
     color: var(--midgrey);
     text-align: center;
     font-size: 1.4rem;

core/client/app/styles/layouts/tags.css

@@ -109,7 +109,7 @@
 
 .settings-tag .tag-description {
     margin: 0;
-    color: #dfe1e3;
+    color: color(#dfe1e3 lightness(-10%));
     font-size: 13px;
 }
 
@@ -117,6 +117,6 @@
     position: absolute;
     top: 20px;
     right: 12px;
-    color: #dfe1e3;
+    color: color(#dfe1e3 lightness(-10%));
     font-size: 16px;
 }

core/client/app/styles/patterns/buttons.css

@@ -3,9 +3,6 @@
 
 /* Base button style */
 .btn {
-    display: flex;
-    justify-content: center;
-    align-items: center;
     margin-bottom: 0;
     padding: 9px 15px;
     border: #dfe1e3 1px solid;
@@ -163,6 +160,7 @@ fieldset[disabled] .btn {
 .btn-minor:focus {
     border-color: #c1c1c1;
     background: #fff;
+    box-shadow: none;
     color: #808284;
 }
 

core/client/app/templates/about.hbs

@@ -2,7 +2,7 @@
     <section class="view-content">
         <header class="gh-about-header">
             <img class="gh-logo" src="{{gh-path 'admin' '/img/ghost-logo.png'}}" alt="Ghost" />
-            <!-- TODO: fix about notifications -->
+            {{!-- TODO: fix about notifications --}}
             {{gh-notifications location="about-upgrade" notify="updateNotificationChange"}}
         </header>
 

core/client/app/templates/components/gh-modal-dialog.hbs

@@ -8,13 +8,8 @@
             </section>
             {{#if confirm}}
             <footer class="modal-footer">
-                <button type="button" class="{{rejectButtonClass}} btn-minor js-button-reject" {{action "confirm" "reject"}}>
+                {{! Buttons must be on one line to prevent white-space errors }}
-                    {{confirm.reject.text}}
+                <button type="button" class="{{rejectButtonClass}} btn-minor js-button-reject" {{action "confirm" "reject"}}>{{confirm.reject.text}}</button><button type="button" class="{{acceptButtonClass}} js-button-accept" {{action "confirm" "accept"}}>{{confirm.accept.text}}</button>
-                </button><!--
-                Required to strip the white-space between buttons
-                --><button type="button" class="{{acceptButtonClass}} js-button-accept" {{action "confirm" "accept"}}>
-                    {{confirm.accept.text}}
-                </button>
             </footer>
             {{/if}}
         </section>

core/client/app/templates/posts.hbs

@@ -1,6 +1,6 @@
 <section class="gh-view content-view-container">
 <header class="view-header">
-    {{#gh-view-title openMobileMenu="openMobileMenu"}}Content{{/gh-view-title}}
+    {{#gh-view-title openMobileMenu="openMobileMenu"}}<span>Content</span>{{/gh-view-title}}
     <section class="view-actions">
         {{#link-to "editor.new" class="btn btn-green" title="New Post"}}New Post{{/link-to}}
     </section>

core/client/app/templates/settings/code-injection.hbs

@@ -1,6 +1,6 @@
 <section class="gh-view">
     <header class="view-header">
-        {{#gh-view-title openMobileMenu="openMobileMenu"}}Code Injection{{/gh-view-title}}
+        {{#gh-view-title openMobileMenu="openMobileMenu"}}<span>Code Injection</span>{{/gh-view-title}}
         <section class="view-actions">
             {{gh-spin-button type="button" class="btn btn-blue" action="save" buttonText="Save" submitting=submitting}}
         </section>

core/client/app/templates/settings/general.hbs

@@ -1,6 +1,6 @@
 <section class="gh-view">
     <header class="view-header">
-        {{#gh-view-title openMobileMenu="openMobileMenu"}}General{{/gh-view-title}}
+        {{#gh-view-title openMobileMenu="openMobileMenu"}}<span>General</span>{{/gh-view-title}}
         <section class="view-actions">
             {{gh-spin-button type="button" class="btn btn-blue" action="save" buttonText="Save" submitting=submitting}}
         </section>

core/client/app/templates/settings/labs.hbs

@@ -1,6 +1,6 @@
 <section class="gh-view">
     <header class="view-header">
-        {{#gh-view-title openMobileMenu="openMobileMenu"}}Labs{{/gh-view-title}}
+        {{#gh-view-title openMobileMenu="openMobileMenu"}}<span>Labs</span>{{/gh-view-title}}
     </header>
 
     <section class="view-content settings-debug">

core/client/app/templates/settings/navigation.hbs

@@ -1,6 +1,6 @@
 {{#gh-navigation moveItem="moveItem"}}
     <header class="view-header">
-        {{#gh-view-title openMobileMenu="openMobileMenu"}}Navigation{{/gh-view-title}}
+        {{#gh-view-title openMobileMenu="openMobileMenu"}}<span>Navigation</span>{{/gh-view-title}}
         <section class="view-actions">
             {{gh-spin-button type="button" class="btn btn-blue" action="save" buttonText="Save" submitting=submitting}}
         </section>

core/client/app/templates/settings/tags.hbs

@@ -1,6 +1,6 @@
 <section class="gh-view">
     <header class="view-header">
-        {{#gh-view-title openMobileMenu="openMobileMenu"}}Tags{{/gh-view-title}}
+        {{#gh-view-title openMobileMenu="openMobileMenu"}}<span>Tags</span>{{/gh-view-title}}
         <section class="view-actions">
             <button type="button" class="btn btn-green" {{action "newTag"}}>New Tag</button>
         </section>

core/client/app/templates/team/index.hbs

@@ -1,6 +1,6 @@
 <section class="gh-view">
     <header class="view-header">
-        {{#gh-view-title openMobileMenu="openMobileMenu"}}Team{{/gh-view-title}}
+        {{#gh-view-title openMobileMenu="openMobileMenu"}}<span>Team</span>{{/gh-view-title}}
         {{!-- Do not show Invite user button to authors --}}
         {{#unless session.user.isAuthor}}
             <section class="view-actions">

core/client/app/templates/team/user.hbs

@@ -2,7 +2,7 @@
     <header class="view-header">
         {{#gh-view-title openMobileMenu="openMobileMenu"}}
             {{link-to "Team" "team"}}
-            <i class="icon-arrow-right"></i> {{user.name}}
+            <i class="icon-arrow-right"></i> <span>{{user.name}}</span>
         {{/gh-view-title}}
         <section class="view-actions">
             {{#if userActionsAreVisible}}