From 71aa1c58e6ee5b98f1b444f4e2b5dc54921884c8 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Wed, 18 May 2022 10:30:44 +0100 Subject: [PATCH] Revert "Cleaned up `membersActivityFeed` labs flag" This reverts commit ae3a0e93fcc359339ef419a944ccd5fb3c380c08. - flag is still used in the `@tryghost/members-api` package - reverting for now pending a more complete commit with a bumped members-api package --- core/shared/labs.js | 1 + test/e2e-api/admin/__snapshots__/settings.test.js.snap | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/core/shared/labs.js b/core/shared/labs.js index 0baef09b86..2b3a39f887 100644 --- a/core/shared/labs.js +++ b/core/shared/labs.js @@ -22,6 +22,7 @@ const GA_FEATURES = [ 'membersTableStatus', 'multipleNewsletters', 'multipleNewslettersUI', + 'membersActivityFeed', 'dashboardV5' ]; diff --git a/test/e2e-api/admin/__snapshots__/settings.test.js.snap b/test/e2e-api/admin/__snapshots__/settings.test.js.snap index abf6f97ded..5ca16ee38d 100644 --- a/test/e2e-api/admin/__snapshots__/settings.test.js.snap +++ b/test/e2e-api/admin/__snapshots__/settings.test.js.snap @@ -230,7 +230,7 @@ Object { }, Object { "key": "labs", - "value": "{\\"activitypub\\":true,\\"urlCache\\":true,\\"beforeAfterCard\\":true,\\"tweetGridCard\\":true,\\"multipleProducts\\":true,\\"tierWelcomePages\\":true,\\"tierName\\":true,\\"selectablePortalLinks\\":true,\\"membersTableStatus\\":true,\\"multipleNewsletters\\":true,\\"multipleNewslettersUI\\":true,\\"dashboardV5\\":true,\\"members\\":true}", + "value": "{\\"activitypub\\":true,\\"urlCache\\":true,\\"beforeAfterCard\\":true,\\"tweetGridCard\\":true,\\"multipleProducts\\":true,\\"tierWelcomePages\\":true,\\"tierName\\":true,\\"selectablePortalLinks\\":true,\\"membersTableStatus\\":true,\\"multipleNewsletters\\":true,\\"multipleNewslettersUI\\":true,\\"membersActivityFeed\\":true,\\"dashboardV5\\":true,\\"members\\":true}", }, Object { "key": "slack_url", @@ -280,7 +280,7 @@ exports[`Settings API Browse Can request all settings 2: [headers] 1`] = ` Object { "access-control-allow-origin": "http://127.0.0.1:2369", "cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0", - "content-length": "3594", + "content-length": "3623", "content-type": "application/json; charset=utf-8", "etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/, "vary": "Origin, Accept-Encoding", @@ -1340,7 +1340,7 @@ Object { }, Object { "key": "labs", - "value": "{\\"multipleProducts\\":true,\\"tierWelcomePages\\":true,\\"tierName\\":true,\\"selectablePortalLinks\\":true,\\"membersTableStatus\\":true,\\"multipleNewsletters\\":true,\\"multipleNewslettersUI\\":true,\\"dashboardV5\\":true,\\"members\\":true}", + "value": "{\\"multipleProducts\\":true,\\"tierWelcomePages\\":true,\\"tierName\\":true,\\"selectablePortalLinks\\":true,\\"membersTableStatus\\":true,\\"multipleNewsletters\\":true,\\"multipleNewslettersUI\\":true,\\"membersActivityFeed\\":true,\\"dashboardV5\\":true,\\"members\\":true}", }, Object { "key": "timezone", @@ -1358,7 +1358,7 @@ exports[`Settings API Edit Can edit a setting 2: [headers] 1`] = ` Object { "access-control-allow-origin": "http://127.0.0.1:2369", "cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0", - "content-length": "1083", + "content-length": "1112", "content-type": "application/json; charset=utf-8", "etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/, "vary": "Origin, Accept-Encoding",