Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-04-01 02:41:39 -05:00
Code Issues Activity

Fixed failing Stripe webhook test

Browse source 
refs acf0baa8c7

Due to the bump in express-test, we now handle string bodies 'properly'. So they now pass all the Express middlewares. In the past this failing test did not really pass by the bodyParser.raw middleware,
so the content-type check on the `bodyParser.raw({type: 'application/json'})` middleware was not executed. Now it is, and the test fails because the content-type header was not set to application/json.
This commit is contained in:
Simon Backx 2023-01-18 11:59:18 +01:00
parent acf0baa8c7
commit 6c2af0793c
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
ghost/core/test/e2e-api/members/webhooks.test.js
View file

@ -176,6 +176,7 @@ describe('Members API', function () {
await membersAgent.post('/webhooks/stripe/')
.body(webhookPayload)
.header('content-type', 'application/json')
.header('stripe-signature', webhookSignature)
.expectStatus(200);
});
@ -307,6 +308,7 @@ describe('Members API', function () {
await membersAgent.post('/webhooks/stripe/')
.body(webhookPayload)
.header('content-type', 'application/json')
.header('stripe-signature', webhookSignature)
.expectStatus(200);
@ -516,6 +518,7 @@ describe('Members API', function () {
await membersAgent.post('/webhooks/stripe/')
.body(webhookPayload)
.header('content-type', 'application/json')
.header('stripe-signature', webhookSignature)
.expectStatus(200);
@ -649,6 +652,7 @@ describe('Members API', function () {
await membersAgent.post('/webhooks/stripe/')
.body(webhookPayload)
.header('content-type', 'application/json')
.header('stripe-signature', webhookSignature);
const {body} = await adminAgent.get('/members/?search=checkout-webhook-test@email.com');
@ -747,6 +751,7 @@ describe('Members API', function () {
await membersAgent.post('/webhooks/stripe/')
.body(webhookPayload)
.header('content-type', 'application/json')
.header('stripe-signature', webhookSignature);
const {body} = await adminAgent.get('/members/?search=checkout-newsletter-default-test@email.com');
@ -795,6 +800,7 @@ describe('Members API', function () {
await membersAgent.post('/webhooks/stripe/')
.body(webhookPayload)
.header('content-type', 'application/json')
.header('stripe-signature', webhookSignature);
const {body} = await adminAgent.get('/members/?search=checkout-newsletter-test@email.com');
@ -865,6 +871,7 @@ describe('Members API', function () {
await membersAgent.post('/webhooks/stripe/')
.body(webhookPayload)
.header('content-type', 'application/json')
.header('stripe-signature', webhookSignature)
.expectStatus(200);
});
@ -993,6 +1000,7 @@ describe('Members API', function () {
await membersAgent.post('/webhooks/stripe/')
.body(webhookPayload)
.header('content-type', 'application/json')
.header('stripe-signature', webhookSignature)
.expectStatus(200);
@ -1054,6 +1062,7 @@ describe('Members API', function () {
await membersAgent.post('/webhooks/stripe/')
.body(webhookPayload)
.header('content-type', 'application/json')
.header('stripe-signature', webhookSignature)
.expectStatus(200);
@ -1390,6 +1399,7 @@ describe('Members API', function () {
await membersAgent.post('/webhooks/stripe/')
.body(webhookPayload)
.header('content-type', 'application/json')
.header('stripe-signature', webhookSignature);
const {body} = await adminAgent.get(`/members/?search=${customer_id}@email.com`);
@ -1448,6 +1458,7 @@ describe('Members API', function () {
await membersAgent.post('/webhooks/stripe/')
.body(webhookPayload)
.header('content-type', 'application/json')
.header('stripe-signature', webhookSignature)
.expectStatus(200);
@ -1586,6 +1597,7 @@ describe('Members API', function () {
await membersAgent.post('/webhooks/stripe/')
.body(webhookPayload)
.header('content-type', 'application/json')
.header('stripe-signature', webhookSignature);
const {body} = await adminAgent.get(`/members/?search=${customer_id}@email.com`);
@ -1749,6 +1761,7 @@ describe('Members API', function () {
await membersAgent.post('/webhooks/stripe/')
.body(webhookPayload)
.header('content-type', 'application/json')
.header('stripe-signature', webhookSignature)
.expectStatus(200);