From b4a0b1498fa30c03fa3ad6bbd0a7b074df62b9fe Mon Sep 17 00:00:00 2001 From: James Inman Date: Tue, 20 Aug 2013 20:27:54 +0100 Subject: [PATCH] Adding fade transitions between settings tabs. Closes #371 - Added a hide and fadeIn() to the render method in Settings.Pane - Any Settings.Pane which overwrites render should now make sure the parent is called - Run through grunt validate, all OK. --- core/client/views/settings.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/core/client/views/settings.js b/core/client/views/settings.js index ce8ef09469..92c4886727 100644 --- a/core/client/views/settings.js +++ b/core/client/views/settings.js @@ -86,7 +86,11 @@ this.$el.removeClass('active'); this.undelegateEvents(); }, - + render: function () { + this.$el.hide(); + Ghost.View.prototype.render.call(this); + this.$el.fadeIn(300); + }, afterRender: function () { this.$el.attr('id', this.id); this.$el.addClass('active');