Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Refactored labs dependency out of MembersCSVImporter

Browse source 
refs https://github.com/TryGhost/Team/issues/916

-  The refactor was done follow the DI Constructor pattern and prepare module for extraction
This commit is contained in:
Naz 2021-07-20 18:42:57 +04:00 • committed by naz
parent c3b60a5628
commit 6a8384cafb
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
ghost/members-importer/lib/importer.js
View file

@ -9,7 +9,6 @@ const urlUtils = require('../../../../shared/url-utils');
const db = require('../../../data/db'); const db = require('../../../data/db');
const emailTemplate = require('./email-template'); const emailTemplate = require('./email-template');
const jobsService = require('../../jobs'); const jobsService = require('../../jobs');
const labsService = require('../../../../shared/labs');
const messages = { const messages = {
filenameCollision: 'Filename already exists, please try again.', filenameCollision: 'Filename already exists, please try again.',
@ -22,13 +21,15 @@ module.exports = class MembersCSVImporter {
* @param {string} config.storagePath - The path to store CSV's in before importing * @param {string} config.storagePath - The path to store CSV's in before importing
* @param {Object} settingsCache - An instance of the Ghost Settings Cache * @param {Object} settingsCache - An instance of the Ghost Settings Cache
* @param {Object} ghostMailer - An instance of GhostMailer * @param {Object} ghostMailer - An instance of GhostMailer
* @param {(string) => boolean} isSet - Method checking if specific feature is enabled
* @param {() => Object} getMembersApi * @param {() => Object} getMembersApi
*/ */
constructor(config, settingsCache, getMembersApi, ghostMailer) { constructor(config, settingsCache, getMembersApi, ghostMailer, isSet) {
this._storagePath = config.storagePath; this._storagePath = config.storagePath;
this._settingsCache = settingsCache; this._settingsCache = settingsCache;
this._getMembersApi = getMembersApi; this._getMembersApi = getMembersApi;
this._ghostMailer = ghostMailer; this._ghostMailer = ghostMailer;
this._isSet = isSet;
} }
/** /**
@ -156,7 +157,7 @@ module.exports = class MembersCSVImporter {
member_id: member.id member_id: member.id
}, options); }, options);
} else if (row.complimentary_plan) { } else if (row.complimentary_plan) {
if (!labsService.isSet('multipleProducts')) { if (!this._isSet('multipleProducts')) {
await membersApi.members.setComplimentarySubscription(member, options); await membersApi.members.setComplimentarySubscription(member, options);
} else if (!row.products) { } else if (!row.products) {
await membersApi.members.update({ await membersApi.members.update({
@ -168,7 +169,7 @@ module.exports = class MembersCSVImporter {
} }
} }
if (labsService.isSet('multipleProducts')) { if (this._isSet('multipleProducts')) {
if (row.products) { if (row.products) {
await membersApi.members.update({ await membersApi.members.update({
products: row.products products: row.products