Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

Fixed imports for files missing the email_only key (#13284)

Browse source 
closes https://github.com/TryGhost/Team/issues/1024

Our importer would set the default value of all posts_meta keys to
`null`. This is an invalid value for the `email_only` key which only
accepts booleans.

Since we are already looping over the schema to create the default
values, we can use the `defaultTo` property in the schema to use the
intended default, and fall back to `null` if it doesn't exist.

We've used the `Reflect.has` function to determine if the `defaultTo`
key exists, as opposed to a truthy check, because it's possible that a
falsy value (e.g. false, in the case of email_only) can be used as the
default.
This commit is contained in:
Fabien 'egg' O'Carroll 2021-09-06 12:51:42 +02:00 • committed by Daniel Lockyer
parent 35e23636ae
commit 6a7cd9856e
No known key found for this signature in database
GPG key ID: D21186F0B47295AD
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/server/data/importer/importers/data/posts.js
View file

@ -50,7 +50,9 @@ class PostsImporter extends BaseImporter {
*/ */
sanitizePostsMeta(model) { sanitizePostsMeta(model) {
let postsMetaFromFile = _.find(this.requiredFromFile.posts_meta, {post_id: model.id}) || _.pick(model, metaAttrs); let postsMetaFromFile = _.find(this.requiredFromFile.posts_meta, {post_id: model.id}) || _.pick(model, metaAttrs);
let postsMetaData = Object.assign({}, _.mapValues(postsMetaSchema, () => null), postsMetaFromFile); let postsMetaData = Object.assign({}, _.mapValues(postsMetaSchema, (value) => {
return Reflect.has(value, 'defaultTo') ? value.defaultTo : null;
}), postsMetaFromFile);
model.posts_meta = postsMetaData; model.posts_meta = postsMetaData;
_.each(metaAttrs, (attr) => { _.each(metaAttrs, (attr) => {
delete model[attr]; delete model[attr];