From 6512fc770d20c6d56abdfe1923552c6a10e83ef0 Mon Sep 17 00:00:00 2001
From: Sam Lord <sam@ghost.org>
Date: Tue, 28 Feb 2023 10:41:35 +0000
Subject: [PATCH] Prevent xmlprc tests from outputting errors for failure cases

refs: https://github.com/TryGhost/Toolbox/issues/389
---
 ghost/core/test/unit/server/services/xmlrpc.test.js | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/ghost/core/test/unit/server/services/xmlrpc.test.js b/ghost/core/test/unit/server/services/xmlrpc.test.js
index d6439b2d93..86a541baf7 100644
--- a/ghost/core/test/unit/server/services/xmlrpc.test.js
+++ b/ghost/core/test/unit/server/services/xmlrpc.test.js
@@ -10,6 +10,7 @@ const logging = require('@tryghost/logging');
 
 describe('XMLRPC', function () {
     let eventStub;
+    let loggingStub;
 
     beforeEach(function () {
         eventStub = sinon.stub(events, 'on');
@@ -75,6 +76,7 @@ describe('XMLRPC', function () {
         const ping = xmlrpc.__get__('ping');
 
         it('with a post should execute two pings', function (done) {
+            loggingStub = sinon.stub(logging, 'error');
             const ping1 = nock('http://rpc.pingomatic.com').post('/').reply(200);
             const testPost = _.clone(testUtils.DataGenerator.Content.posts[2]);
 
@@ -123,7 +125,7 @@ describe('XMLRPC', function () {
         it('captures && logs errors from requests', function (done) {
             const testPost = _.clone(testUtils.DataGenerator.Content.posts[2]);
             const ping1 = nock('http://rpc.pingomatic.com').post('/').reply(400);
-            const loggingStub = sinon.stub(logging, 'error');
+            loggingStub = sinon.stub(logging, 'error');
 
             ping(testPost);
 
@@ -166,7 +168,7 @@ describe('XMLRPC', function () {
                </params>
              </methodResponse>`);
 
-            const loggingStub = sinon.stub(logging, 'error');
+            loggingStub = sinon.stub(logging, 'error');
 
             ping(testPost);
 
@@ -209,7 +211,7 @@ describe('XMLRPC', function () {
                </params>
              </methodResponse>`).replace('\n', ''));
 
-            const loggingStub = sinon.stub(logging, 'error');
+            loggingStub = sinon.stub(logging, 'error');
 
             ping(testPost);
 
@@ -242,7 +244,7 @@ describe('XMLRPC', function () {
                   </params>
                 </methodResponse>`);
 
-            const loggingStub = sinon.stub(logging, 'error');
+            loggingStub = sinon.stub(logging, 'error');
 
             ping(testPost);
 
@@ -257,6 +259,7 @@ describe('XMLRPC', function () {
         });
 
         it('should behave correctly when getting a 429', function (done) {
+            loggingStub = sinon.stub(logging, 'error');
             const ping1 = nock('http://rpc.pingomatic.com').post('/').reply(429);
             const testPost = _.clone(testUtils.DataGenerator.Content.posts[2]);