🐛 Fixed dashboard appearing blank if members disabled before completing onboarding

closes https://linear.app/tryghost/issue/ONC-106

- moved onboarding display outside of the `isMembersEnabled` conditional block

ghost/admin/app/templates/dashboard.hbs

@@ -85,13 +85,10 @@
             {{#if this.isLoading }}
                 <GhLoadingSpinner />
             {{else}}
-                {{#if this.areMembersEnabled}}
-
                 {{#if this.onboarding.isChecklistShown}}
                     <Dashboard::OnboardingChecklist />
                 {{/if}}
-
+                {{#if (and this.areMembersEnabled (not this.onboarding.isChecklistShown))}}
-                    {{#unless this.onboarding.isChecklistShown}}
                     {{#if this.hasPaidTiers}}
                         <Dashboard::Charts::Overview />
                     {{/if}}
@@ -116,7 +113,6 @@
                             <Dashboard::Parts::Zero />
                         {{/if}}
                     </div>
-                    {{/unless}}
                 {{/if}}
 
                 {{#unless this.onboarding.isChecklistShown}}

ghost/admin/tests/acceptance/onboarding-test.js

@@ -50,6 +50,19 @@ describe('Acceptance: Onboarding', function () {
             expect(find('[data-test-dashboard="header"]'), 'header').to.not.exist;
             expect(find('[data-test-dashboard="attribution"]'), 'attribution section').to.not.exist;
         });
+
+        it('checklist is shown when members disabled', async function () {
+            this.server.db.settings.update({membersSignupAccess: 'none'});
+            await visit('/setup/done');
+            await visit('/dashboard');
+
+            // onboarding is't shown
+            expect(find('[data-test-dashboard="onboarding-checklist"]'), 'checklist').to.exist;
+
+            // other default dashboard elements are not visible
+            expect(find('[data-test-dashboard="header"]'), 'header').to.not.exist;
+            expect(find('[data-test-dashboard="attribution"]'), 'attribution section').to.not.exist;
+        });
     });
 
     describe('checklist (non-owner)', function () {