From 635c2614a3f88f5a3f773edab3071a801b249669 Mon Sep 17 00:00:00 2001
From: Fabien O'Carroll <fabien@allou.is>
Date: Tue, 2 Nov 2021 15:34:02 +0200
Subject: [PATCH] Fixed errors for non-subscription invoices

refs https://github.com/TryGhost/Team/issues/887

Our invoice webhook handling code assumed that every invoice would be
for a subscription, but that is not the case. There are valid use-cases
of using the same Stripe account in order to sell items with a one-off
purchase. Here we update the handling to ignore all invoices which are
not for subscriptions.
---
 ghost/members-api/lib/services/stripe-webhook.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ghost/members-api/lib/services/stripe-webhook.js b/ghost/members-api/lib/services/stripe-webhook.js
index eadd03165b..8b615bc8d1 100644
--- a/ghost/members-api/lib/services/stripe-webhook.js
+++ b/ghost/members-api/lib/services/stripe-webhook.js
@@ -155,6 +155,9 @@ module.exports = class StripeWebhookService {
      * @returns {Promise<void>}
      */
     async invoiceEvent(invoice) {
+        if (!invoice.subscription) {
+            return;
+        }
         const subscription = await this._stripeAPIService.getSubscription(invoice.subscription, {
             expand: ['default_payment_method']
         });