From af43bb92671ea366ebdc0affbc4f6b47439abe10 Mon Sep 17 00:00:00 2001
From: Peter Szel <szelpeter@szelpeter.hu>
Date: Sun, 28 Feb 2016 00:45:56 +0000
Subject: [PATCH] Fixed bugs regarding the published date input field
 validation. refs #5777

- removing error message from the previous validation
- only checking if date is in the past if the input date is valid to begin with
- always updating the view, even if the date hasn't changed to make sure the date format stays consistent
---
 .../app/controllers/post-settings-menu.js     | 22 ++++++++++---------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/ghost/admin/app/controllers/post-settings-menu.js b/ghost/admin/app/controllers/post-settings-menu.js
index 3662eefd1d..6db46a63fb 100644
--- a/ghost/admin/app/controllers/post-settings-menu.js
+++ b/ghost/admin/app/controllers/post-settings-menu.js
@@ -290,10 +290,6 @@ export default Controller.extend(SettingsMenuMixin, {
          * (#1351)
          */
         setPublishedAt(userInput) {
-            let newPublishedAt = parseDateString(userInput);
-            let publishedAt = moment(this.get('model.publishedAt'));
-            let errMessage = '';
-
             if (!userInput) {
                 // Clear out the publishedAt field for a draft
                 if (this.get('model.isDraft')) {
@@ -303,12 +299,18 @@ export default Controller.extend(SettingsMenuMixin, {
                 return;
             }
 
+            let newPublishedAt = parseDateString(userInput);
+            let publishedAt = moment(this.get('model.publishedAt'));
+            let errMessage = '';
+
+            // Clear previous errors
+            this.get('model.errors').remove('post-setting-date');
+
             // Validate new Published date
             if (!newPublishedAt.isValid()) {
                 errMessage = 'Published Date must be a valid date with format: ' +
                     'DD MMM YY @ HH:mm (e.g. 6 Dec 14 @ 15:00)';
-            }
-            if (newPublishedAt.diff(new Date(), 'h') > 0) {
+            } else if (newPublishedAt.diff(new Date(), 'h') > 0) {
                 errMessage = 'Published Date cannot currently be in the future.';
             }
 
@@ -318,14 +320,14 @@ export default Controller.extend(SettingsMenuMixin, {
                 return;
             }
 
-            // Do nothing if the user didn't actually change the date
+            // Validation complete, update the view
+            this.set('model.publishedAt', newPublishedAt);
+
+            // Don't save the date if the user didn't actually changed the date
             if (publishedAt && publishedAt.isSame(newPublishedAt)) {
                 return;
             }
 
-            // Validation complete
-            this.set('model.publishedAt', newPublishedAt);
-
             // If this is a new post.  Don't save the model.  Defer the save
             // to the user pressing the save button
             if (this.get('model.isNew')) {