Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Updated active column type from boolean -> bool

Browse source 
no-issue

Our base model will only automatically convert numbers to booleans if
the type is 'bool' - however this column was incorrectly added with a
type of 'boolean'. Lucklily - knex with both MySQL & SQLite3 will add
a column with the same type for both of these, so no migration is needed
to fix it.
This commit is contained in:
Fabien O'Carroll 2021-05-07 16:37:38 +01:00
parent e1f0eb8794
commit 6106d1fdc4
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/server/data/migrations/versions/4.3/06-add-stripe-prices-table.js
View file

@ -4,7 +4,7 @@ module.exports = addTable('stripe_prices', {
id: {type: 'string', maxlength: 24, nullable: false, primary: true},
stripe_price_id: {type: 'string', maxlength: 255, nullable: false, unique: true},
stripe_product_id: {type: 'string', maxlength: 255, nullable: false, unique: false, references: 'stripe_products.stripe_product_id', cascadeDelete: true},
active: {type: 'boolean', nullable: false},
active: {type: 'bool', nullable: false},
nickname: {type: 'string', maxlength: 50, nullable: true},
currency: {type: 'string', maxLength: 3, nullable: false},
amount: {type: 'integer', nullable: false},

2
core/server/data/schema/schema.js
View file

@ -490,7 +490,7 @@ module.exports = {
id: {type: 'string', maxlength: 24, nullable: false, primary: true},
stripe_price_id: {type: 'string', maxlength: 255, nullable: false, unique: true},
stripe_product_id: {type: 'string', maxlength: 255, nullable: false, unique: false, references: 'stripe_products.stripe_product_id'},
active: {type: 'boolean', nullable: false},
active: {type: 'bool', nullable: false},
nickname: {type: 'string', maxlength: 50, nullable: true},
currency: {type: 'string', maxLength: 3, nullable: false},
amount: {type: 'integer', nullable: false},

2
test/unit/data/schema/integrity_spec.js
View file

@ -32,7 +32,7 @@ const defaultSettings = require('../../../../core/server/data/schema/default-set
*/
describe('DB version integrity', function () {
// Only these variables should need updating
const currentSchemaHash = '7886f066821a240b85c6b61ba2dcff65';
const currentSchemaHash = 'ffa4eec4208614b93b6b8fb68b55f126';
const currentFixturesHash = '8671672598d2a62e53418c4b91aa79a3';
const currentSettingsHash = '1f41d1a0a21500bcaf2829288dff5a67';
const currentRoutesHash = '3d180d52c663d173a6be791ef411ed01';