Enabled page features (#17544)

no refs
-moved hide page title and feature image to GA
-updated gscan

apps/admin-x-settings/test/utils/responses/themes.json

@@ -53,7 +53,7 @@
                     "autoprefixer": "10.4.7",
                     "beeper": "2.1.0",
                     "cssnano": "5.1.12",
-                    "gscan": "4.37.3",
+                    "gscan": "4.37.4",
                     "gulp": "4.0.2",
                     "gulp-concat": "2.6.1",
                     "gulp-livereload": "4.0.2",
@@ -315,7 +315,7 @@
                     "autoprefixer": "10.4.14",
                     "beeper": "2.1.0",
                     "cssnano": "6.0.1",
-                    "gscan": "4.37.3",
+                    "gscan": "4.37.4",
                     "gulp": "4.0.2",
                     "gulp-concat": "2.6.1",
                     "gulp-livereload": "4.0.2",

ghost/admin/app/components/gh-koenig-editor-lexical.hbs

@@ -15,18 +15,18 @@
             @caption={{@featureImageCaption}}
             @updateCaption={{@setFeatureImageCaption}}
             @forceButtonDisplay={{or (not @title) (eq @title "(Untitled)") this.titleIsHovered this.titleIsFocused}}
-            @isHidden={{and (feature 'pageImprovements') (not @cardOptions.post.showTitleAndFeatureImage)}}
+            @isHidden={{or (not @cardOptions.post.showTitleAndFeatureImage) false}}
         />
 
-        <div class="gh-editor-title-container {{if (feature "pageImprovements") "page-improvements"}}">
+        <div class="gh-editor-title-container page-improvements">
-            {{#if (and (feature 'pageImprovements') (not @cardOptions.post.showTitleAndFeatureImage) (not @featureImage))}}
+            {{#if (and (not @cardOptions.post.showTitleAndFeatureImage) (not @featureImage))}}
                 <span class="gh-editor-hidden-indicator" data-tooltip="Post title is hidden on page">
                     {{svg-jar "eye-closed"}}
                 </span>
             {{/if}}
 
             <GhTextarea
-                @class="gh-editor-title {{if (and (not @cardOptions.post.showTitleAndFeatureImage) (feature 'pageImprovements') (not this.titleIsFocused)) "faded"}}"
+                @class="gh-editor-title {{if (and (not @cardOptions.post.showTitleAndFeatureImage) (not this.titleIsFocused)) "faded"}}"
                 @placeholder={{@titlePlaceholder}}
                 @shouldFocus={{or @titleAutofocus false}}
                 @tabindex="1"

ghost/admin/app/components/gh-post-settings-menu.hbs

@@ -123,7 +123,7 @@
                     </section>
 
                     <ul class="nav-list">
-                        {{#if (and this.post.isPage this.post.lexical (feature 'pageImprovements'))}}
+                        {{#if (and this.post.isPage this.post.lexical)}}
                             <li class="nav-list-item">
                                 <div class="for-switch x-small">
                                     <label class="switch">

ghost/admin/app/models/theme.js

@@ -76,13 +76,13 @@ export default Model.extend({
 
     hasPageBuilderFeature(feature) {
         const failures = this.codedErrorsAndWarnings;
-
+        
         if (!failures['GS110-NO-MISSING-PAGE-BUILDER-USAGE']) {
             return true;
         }
 
         return !failures['GS110-NO-MISSING-PAGE-BUILDER-USAGE'].some((failure) => {
-            return failure.failures.some(({ref}) => ref === `@page.${feature}`);
+            return failure.failures.some(({message}) => message.includes(`@page.${feature}`));
         });
     },
 

ghost/admin/app/services/feature.js

@@ -73,7 +73,6 @@ export default class FeatureService extends Service {
     @feature('signupForm') signupForm;
     @feature('collections') collections;
     @feature('adminXSettings') adminXSettings;
-    @feature('pageImprovements') pageImprovements;
     @feature('flatUrls') flatUrls;
     @feature('mailEvents') mailEvents;
     @feature('collectionsCard') collectionsCard;

ghost/admin/app/templates/settings/labs.hbs

@@ -311,20 +311,6 @@
                     </div>
                 </div>
 
-                <div class="gh-expandable-block">
-                    <div class="gh-expandable-header">
-                        <div>
-                            <h4 class="gh-expandable-title">Page improvements</h4>
-                            <p class="gh-expandable-description">
-                                Enables toggling off page title and feature image
-                            </p>
-                        </div>
-                        <div class="for-switch">
-                            <GhFeatureFlag @flag="pageImprovements" />
-                        </div>
-                    </div>
-                </div>
-
                 <div class="gh-expandable-block">
                     <div class="gh-expandable-header">
                         <div>

ghost/core/core/shared/labs.js

@@ -38,7 +38,6 @@ const ALPHA_FEATURES = [
     'emailCustomization',
     'collections',
     'adminXSettings',
-    'pageImprovements',
     'flatUrls',
     'mailEvents',
     'collectionsCard',

ghost/core/package.json

@@ -188,7 +188,7 @@
     "ghost-storage-base": "1.0.0",
     "glob": "8.1.0",
     "got": "11.8.6",
-    "gscan": "4.37.3",
+    "gscan": "4.37.4",
     "human-number": "2.0.1",
     "image-size": "1.0.2",
     "intl": "1.2.5",

ghost/core/test/utils/fixtures/themes/casper/package.json

@@ -49,7 +49,7 @@
         "autoprefixer": "10.2.5",
         "beeper": "2.1.0",
         "cssnano": "4.1.10",
-        "gscan": "4.37.3",
+        "gscan": "4.37.4",
         "gulp": "4.0.2",
         "gulp-concat": "2.6.1",
         "gulp-livereload": "4.0.2",

yarn.lock

@@ -17179,10 +17179,10 @@ growly@^1.3.0:
   resolved "https://registry.yarnpkg.com/growly/-/growly-1.3.0.tgz#f10748cbe76af964b7c96c93c6bcc28af120c081"
   integrity sha512-+xGQY0YyAWCnqy7Cd++hc2JqMYzlm0dG30Jd0beaA64sROr8C4nt8Yc9V5Ro3avlSUDTN0ulqP/VBKi1/lLygw==
 
-gscan@4.37.3:
+gscan@4.37.4:
-  version "4.37.3"
+  version "4.37.4"
-  resolved "https://registry.yarnpkg.com/gscan/-/gscan-4.37.3.tgz#4a705f3bc5222655fcad378f489f25deac6a60fc"
+  resolved "https://registry.yarnpkg.com/gscan/-/gscan-4.37.4.tgz#d9a05d22f3ad774c947abe8ea2a5af9a69bb3847"
-  integrity sha512-ADpxd72ak/c0gPSoCYwdIZvlKqCJuKb4DtHuk0padqY6nexh7dMdXreL3rXir0w9tlYyIXsqoF8OuJdrIS0G9g==
+  integrity sha512-XI6QazyN9roUJ9kjlwU+qG73XYi8L0mSM0KLm9oLUdhoTFBSHOWUsVVCSu1TJ6z/v0QLmop/dOQYfGinr6bWxg==
   dependencies:
     "@sentry/node" "7.60.1"
     "@tryghost/config" "0.2.17"