From 5fad27a3c027766d9d48a5736b32c397084983a8 Mon Sep 17 00:00:00 2001
From: Hannah Wolfe <github.erisds@gmail.com>
Date: Thu, 15 Dec 2022 16:10:36 +0000
Subject: [PATCH] =?UTF-8?q?=E2=9C=A8=20Added=20html=20->=20mobiledoc=20con?=
 =?UTF-8?q?version=20to=20the=20importer=20(#16016)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Now that the importer runs in a job, it seems sensble that we should
do this
- If posts are imported with HTML set, but not mobiledoc, we now convert html -> mobiledoc
- Note: This also converts the mobiledoc -> html so _may_ be lossy
- Without this, imports that only have HTML, not mobiledoc, would have
resulted in empty posts, so lossy > empty
---
 .../core/core/server/data/importer/importers/data/posts.js  | 4 ++++
 ghost/core/test/integration/importer/v1.test.js             | 6 +++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/ghost/core/core/server/data/importer/importers/data/posts.js b/ghost/core/core/server/data/importer/importers/data/posts.js
index 76f4a30b53..b6cc4c2c19 100644
--- a/ghost/core/core/server/data/importer/importers/data/posts.js
+++ b/ghost/core/core/server/data/importer/importers/data/posts.js
@@ -272,7 +272,11 @@ class PostsImporter extends BaseImporter {
 
                 model.mobiledoc = JSON.stringify(mobiledoc);
                 model.html = mobiledocLib.mobiledocHtmlRenderer.render(JSON.parse(model.mobiledoc));
+            } else if (model.html) {
+                model.mobiledoc = JSON.stringify(mobiledocLib.htmlToMobiledocConverter(model.html));
+                model.html = mobiledocLib.mobiledocHtmlRenderer.render(JSON.parse(model.mobiledoc));
             }
+
             this.sanitizePostsMeta(model);
         });
 
diff --git a/ghost/core/test/integration/importer/v1.test.js b/ghost/core/test/integration/importer/v1.test.js
index c71109a69a..b10fa5a1ea 100644
--- a/ghost/core/test/integration/importer/v1.test.js
+++ b/ghost/core/test/integration/importer/v1.test.js
@@ -74,7 +74,7 @@ describe('Importer 1.0', function () {
                 });
         });
 
-        it('mobiledoc is null, html field is set', function () {
+        it('mobiledoc is null, html field is set, convert html -> mobiledoc', function () {
             const exportData = exportedBodyV1().db[0];
 
             exportData.data.posts[0] = testUtils.DataGenerator.forKnex.createPost({
@@ -95,8 +95,8 @@ describe('Importer 1.0', function () {
                     const posts = result[0].data.map(model => model.toJSON(options));
 
                     posts.length.should.eql(1);
-                    should(posts[0].html).eql(null);
-                    posts[0].mobiledoc.should.eql('{"version":"0.3.1","ghostVersion":"4.0","markups":[],"atoms":[],"cards":[],"sections":[[1,"p",[[0,[],0,""]]]]}');
+                    should(posts[0].html).eql('<h1 id="this-is-my-post-content">This is my post content.</h1>');
+                    posts[0].mobiledoc.should.eql('{"version":"0.3.1","atoms":[],"cards":[],"markups":[],"sections":[[1,"h1",[[0,[],0,"This is my post content."]]]]}');
                 });
         });