Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

🐛 Fixed missing publication icon in newsletter emails

Browse source 
no issue

Email template was incorrectly setting up publication icon url in case of subdirectory setup, leading to missing publication logo from newsletter emails in such cases. This adds the fix to use correct absolute url for publication icons in all setups.
This commit is contained in:
Rish 2020-03-12 09:52:33 +05:30
parent 2dd374043d
commit 5f349b3ef7
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
core/server/services/mega/post-email-serializer.js
View file

@ -8,8 +8,10 @@ const api = require('../../api');
const {URL} = require('url');
const getSite = () => {
return Object.assign({}, settingsCache.getPublic(), {
url: urlUtils.urlFor('home', true)
const publicSettings = settingsCache.getPublic();
return Object.assign({}, publicSettings, {
url: urlUtils.urlFor('home', true),
iconUrl: publicSettings.icon ? urlUtils.urlFor('image', {image: publicSettings.icon}, true) : null
});
};

4
core/server/services/mega/template.js
View file

@ -809,9 +809,9 @@ figure blockquote p {
<tr>
<td class="site-info" width="100%" align="center">
<table role="presentation" border="0" cellpadding="0" cellspacing="0">
${ site.icon ? `
${ site.iconUrl ? `
<tr>
<td class="site-icon"><a href="${site.url}"><img src="${site.url}${site.icon}" border="0"></a></td>
<td class="site-icon"><a href="${site.url}"><img src="${site.iconUrl}" border="0"></a></td>
</tr>
` : ``}
<tr>