Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

✨ Added embeddable signup form

Browse source 
refs https://github.com/TryGhost/Team/issues/3274

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
Co-authored-by: Ronald Langeveld <hi@ronaldlangeveld.com>
Co-authored-by: Jono Mingard <reason.koan@gmail.com>
Co-authored-by: Sag <guptazy@gmail.com>
This commit is contained in:
Simon Backx 2023-06-09 11:21:18 +02:00
parent 90b9959afc
commit 5e7edb9da5
2 changed files with 3 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
ghost/admin/app/templates/settings/labs.hbs
View file

@ -283,20 +283,6 @@
</div> </div>
</div> </div>
<div class="gh-expandable-block">
<div class="gh-expandable-header">
<div>
<h4 class="gh-expandable-title">Signup Form</h4>
<p class="gh-expandable-description">
Adds an option to generate embed code for the signup form in the email newsletter settings.
</p>
</div>
<div class="for-switch">
<GhFeatureFlag @flag="signupForm" />
</div>
</div>
</div>
<div class="gh-expandable-block"> <div class="gh-expandable-block">
<div class="gh-expandable-header"> <div class="gh-expandable-header">
<div> <div>

6
ghost/core/core/shared/labs.js
View file

@ -18,7 +18,8 @@ const GA_FEATURES = [
'audienceFeedback', 'audienceFeedback',
'themeErrorsNotification', 'themeErrorsNotification',
'outboundLinkTagging', 'outboundLinkTagging',
'announcementBar' 'announcementBar',
'signupForm'
]; ];
// NOTE: this allowlist is meant to be used to filter out any unexpected // NOTE: this allowlist is meant to be used to filter out any unexpected
@ -38,8 +39,7 @@ const ALPHA_FEATURES = [
'emailCustomization', 'emailCustomization',
'signupCard', 'signupCard',
'collections', 'collections',
'adminXSettings', 'adminXSettings'
'signupForm'
]; ];
module.exports.GA_KEYS = [...GA_FEATURES]; module.exports.GA_KEYS = [...GA_FEATURES];