Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

Prevents errors from being logged during the offers tests

Browse source 
refs: https://github.com/TryGhost/Toolbox/issues/389

Intentional errors now call a logging library stub
This commit is contained in:
Sam Lord 2023-03-03 13:48:25 +00:00
parent 8a11ac936d
commit 5b2adbe4c5
1 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
ghost/core/test/e2e-api/admin/offers.test.js
View file

@ -2,6 +2,8 @@ const {agentProvider, fixtureManager, matchers} = require('../../utils/e2e-frame
const {anyContentVersion, anyEtag, anyObjectId, anyLocationFor, anyErrorId} = matchers;
const should = require('should');
const models = require('../../../core/server/models');
const sinon = require('sinon');
const logging = require('@tryghost/logging');
let agent;
@ -25,6 +27,10 @@ describe('Offers API', function () {
defaultTier = await getPaidProduct();
});
this.afterEach(function () {
sinon.restore();
});
it('Has no initial offers', async function () {
await agent
.get(`offers/`)
@ -211,6 +217,8 @@ describe('Offers API', function () {
});
it('Cannot create offer with same code', async function () {
sinon.stub(logging, 'error');
const newOffer = {
name: 'Fourth of July',
code: '4th',
@ -240,6 +248,8 @@ describe('Offers API', function () {
});
it('Cannot create offer with same slugified code', async function () {
sinon.stub(logging, 'error');
const newOffer = {
name: 'Another Black Friday Sale',
code: 'black friday',
@ -269,6 +279,8 @@ describe('Offers API', function () {
});
it('Cannot create offer with same name', async function () {
sinon.stub(logging, 'error');
const newOffer = {
name: 'Fourth of July Sales',
code: 'july4',
@ -385,6 +397,8 @@ describe('Offers API', function () {
});
it('Cannot update offer code to one that exists', async function () {
sinon.stub(logging, 'error');
// We can change all fields except discount related fields
let updatedOffer = {
code: '4th'
@ -406,6 +420,8 @@ describe('Offers API', function () {
});
it('Cannot update offer code to one that exists after it is slugified', async function () {
sinon.stub(logging, 'error');
// We can change all fields except discount related fields
let updatedOffer = {
code: 'Summer sale'
@ -427,6 +443,8 @@ describe('Offers API', function () {
});
it('Cannot update offer name to one that exists', async function () {
sinon.stub(logging, 'error');
// We can change all fields except discount related fields
let updatedOffer = {
name: 'Easter Sales'