Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Removed flaky test

Browse source 
no issue

- This test was checking for a very edge casy scenario (blog timezone change when scheduled date for a post changes at the same time). It's been hard to keep it maintaned so had to go.
This commit is contained in:
Nazar Gargol 2019-12-04 21:14:24 +07:00
parent acd96c19a7
commit 59143de19d
1 changed files with 0 additions and 61 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

61
core/test/regression/models/base/listeners_spec.js
View file

@ -247,67 +247,6 @@ describe('Models: listeners', function () {
.catch(done);
})();
});
it('collision: ensure the listener always succeeds', function (done) {
var timeout,
interval,
post1 = posts[0],
listenerHasFinished = false;
sinon.spy(models.Post, 'findAll');
// simulate a delay, so that the edit operation from the test here interrupts
// the goal here is to force that the listener has old post data, updated_at is then too old
// e.g. user edits while listener is active
listeners.__set__('sequence', function overrideSequence() {
var self = this,
args = arguments;
return Promise.delay(300)
.then(function () {
return sequence.apply(self, args)
.finally(function () {
setTimeout(function () {
listenerHasFinished = true;
}, 50);
});
});
});
scope.timezoneOffset = moment.tz.zone('Asia/Baghdad').utcOffset(now) - moment.tz.zone('Etc/UTC').utcOffset(now);
scope.oldTimezone = 'Asia/Baghdad';
scope.newTimezone = 'Etc/UTC';
eventsToRemember['settings.active_timezone.edited']({
attributes: {value: scope.newTimezone},
_previousAttributes: {value: scope.oldTimezone}
});
models.Post.findAll.calledOnce.should.eql(false);
// set a little timeout to ensure the listener fetched posts from the database and the updated_at difference
// is big enough to simulate the collision scenario
// if you remove the transaction from the listener, this test will fail and show a collision error
timeout = setTimeout(function () {
clearTimeout(timeout);
// ensure findAll was called in the listener
// ensure findAll was called before user's edit operation
models.Post.findAll.calledOnce.should.eql(true);
// simulate a client updates the post during the listener activity
models.Post.edit({title: 'a new title, yes!'}, _.merge({id: post1.id}, testUtils.context.internal))
.then(function () {
interval = setInterval(function () {
if (listenerHasFinished) {
clearInterval(interval);
return done();
}
}, 100);
})
.catch(done);
}, 200);
});
});
describe('db has no scheduled posts', function () {