Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Fixed admin failing tests

Browse source 
no issue

renderInPlace broke tests because expected dropdown changed place in the DOM
This commit is contained in:
Simon Backx 2023-06-08 13:37:23 +02:00
parent f3b60e6c6f
commit 5658f4b627
5 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/components/gh-member-label-input.hbs
View file

@ -6,7 +6,7 @@
@onChange={{this.updateLabels}}
@onCreate={{this.createLabel}}
@options={{this.availableLabels}}
@renderInPlace={{false}}
@renderInPlace={{@renderInPlace}}
@selected={{this.selectedLabels}}
@showCreateWhen={{this.hideCreateOptionOnMatchingLabel}}
@triggerId={{this.triggerId}}

1
ghost/admin/app/components/gh-member-settings-form.hbs
View file

@ -45,6 +45,7 @@
@onLabelEdit={{@onLabelEdit}}
@labels={{this.member.labels}}
@triggerId="label-input"
@renderInPlace={{true}}
data-test-input=""
/>
</GhFormGroup>

1
ghost/admin/app/components/members/filter-value.hbs
View file

@ -30,6 +30,7 @@
@labels={{@filter.value}}
@allowCreation={{false}}
@allowEdit={{true}}
@renderInPlace={{true}}
/>
{{else if (eq @filter.type 'tier_id')}}

2
ghost/admin/app/components/modal-import-members/csv-file-mapping.hbs
View file

@ -18,7 +18,7 @@
<div class="mt6">
<label for="label-input"><span class="fw6 f8 dib mb1">Label these members</span></label>
<GhMemberLabelInput @labels={{this.labels}} @onChange={{this.updateLabels}} @disabled={{@disabled}} @triggerId="label-input" />
<GhMemberLabelInput @labels={{this.labels}} @onChange={{this.updateLabels}} @disabled={{@disabled}} @triggerId="label-input" @renderInPlace={{true}} />
</div>
</GhFormGroup>
{{else}}

1
ghost/admin/app/components/modals/settings/signup-form-embed.hbs
View file

@ -48,6 +48,7 @@
@labels={{this.labels}}
@triggerId="label-input"
@placeholder="Select"
@renderInPlace={{false}}
/>
</div>