Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

🔥 Remove legacy content zero hack (#8156)

Browse source 
refs #7491

- this hack is so legacy I almost forgot about it 😈
- in the beginning of Ghost there were no post images
- someone figured out you could do {{content words="0"}} and it would pull out the first image in your post
- this was never documented, but enough theme developers found it that when we upgraded downsize to get rid of the bug
- we needed to add a hack to keep compatibility.
- This has to die in 🔥  for Ghost 1.0
This commit is contained in:
Hannah Wolfe 2017-03-14 13:56:46 +00:00 • committed by Katharina Irrgang
parent b5cdc01ad1
commit 5605c964e4
3 changed files with 1 additions and 231 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/server/helpers/content.js
View file

@ -9,7 +9,6 @@
var hbs = require('express-hbs'),
_ = require('lodash'),
downsize = require('downsize'),
downzero = require('../utils/downzero'),
content;
content = function (options) {
@ -20,13 +19,6 @@ content = function (options) {
});
if (truncateOptions.hasOwnProperty('words') || truncateOptions.hasOwnProperty('characters')) {
// Legacy function: {{content words="0"}} should return leading tags.
if (truncateOptions.hasOwnProperty('words') && truncateOptions.words === 0) {
return new hbs.handlebars.SafeString(
downzero(this.html)
);
}
return new hbs.handlebars.SafeString(
downsize(this.html, truncateOptions)
);

109
core/server/utils/downzero.js
View file

@ -1,109 +0,0 @@
// Functions to imitate the behavior of Downsize@0.0.5 with 'words: "0"' (heavily based on Downsize)
var stack, tagName, tagBuffer, truncatedText, parseState, pointer,
states = {unitialized: 0, tag_commenced: 1, tag_string: -1, tag_string_single: -2, comment: -3},
voidElements = ['area', 'base', 'br', 'col', 'command', 'embed', 'hr', 'img', 'input',
'keygen', 'link', 'meta', 'param', 'source', 'track', 'wbr'];
function getTagName(tag) {
var tagName = (tag || '').match(/<\/*([a-z0-9\:\-\_]+)/i);
return tagName ? tagName[1] : null;
}
function closeTag(openingTag) {
var tagName = (getTagName(openingTag)) ? '</' + getTagName(openingTag) + '>' : '';
return tagName;
}
function downzero(text) {
stack = [];
tagName = '';
tagBuffer = '';
truncatedText = '';
parseState = 0;
pointer = 0;
for (; pointer < text.length; pointer += 1) {
if (parseState !== states.unitialized) {
tagBuffer += text[pointer];
}
switch (text[pointer]) {
case '<':
if (parseState === states.unitialized && text[pointer + 1].match(/[a-z0-9\-\_\/\!]/)) {
parseState = states.tag_commenced;
tagBuffer += text[pointer];
}
break;
case '!':
if (parseState === states.tag_commenced && text[pointer - 1] === '<') {
parseState = states.comment;
}
break;
case '\"':
if (parseState === states.tag_string) {
parseState = states.tag_commenced;
} else if (parseState === states.tag_string_single) {
// if double quote is found in a single quote string, ignore it and let the string finish
break;
} else if (parseState !== states.unitialized) {
parseState = states.tag_string;
}
break;
case '\'':
if (parseState === states.tag_string_single) {
parseState = states.tag_commenced;
} else if (parseState === states.tag_string) {
break;
} else if (parseState !== states.unitialized) {
parseState = states.tag_string_single;
}
break;
case '>':
if (parseState === states.tag_commenced) {
parseState = states.unitialized;
truncatedText += tagBuffer;
tagName = getTagName(tagBuffer);
if (tagBuffer.match(/<\s*\//) && getTagName(stack[stack.length - 1]) === tagName) {
stack.pop();
} else if (voidElements.indexOf(tagName) < 0 && !tagBuffer.match(/\/\s*>$/)) {
stack.push(tagBuffer);
}
tagBuffer = '';
continue;
}
if (parseState === states.comment && text.substring(pointer - 2, pointer) === '--') {
parseState = states.unitialized;
truncatedText += tagBuffer;
tagBuffer = '';
continue;
}
break;
case '-':
break;
}
if (!parseState) {
break;
}
}
truncatedText += tagBuffer;
while (stack.length) {
truncatedText += closeTag(stack.pop());
}
return truncatedText;
}
module.exports = downzero;

115
core/test/unit/server_helpers/content_spec.js
View file

@ -48,120 +48,7 @@ describe('{{content}} helper', function () {
);
should.exist(rendered);
rendered.string.should.equal('<p></p>');
});
it('can truncate html to 0 words, leaving image tag if it is first', function () {
var html = '<p><img src="example.jpg" />Hello <strong>World! It\'s me!</strong></p>',
rendered = (
helpers.content
.call(
{html: html},
{hash: {words: '0'}}
)
);
should.exist(rendered);
rendered.string.should.equal('<p><img src="example.jpg" /></p>');
});
it('can truncate html to 0 words, leaving image tag with attributes', function () {
var html = '<p><img src="example.png" alt="Alternative" title="Title"></p>',
rendered = (
helpers.content
.call(
{html: html},
{hash: {words: '0'}}
)
);
should.exist(rendered);
rendered.string.should.equal('<p><img src="example.png" alt="Alternative" title="Title"></p>');
});
it('can truncate html to 0 words, leaving first image tag & if alt text has a single quote', function () {
var html = '<p><img src="example.jpg" alt="It\'s me!" />Hello <strong>World! It\'s me!</strong></p>',
rendered = (
helpers.content
.call(
{html: html},
{hash: {words: '0'}}
)
);
should.exist(rendered);
rendered.string.should.equal('<p><img src="example.jpg" alt="It\'s me!" /></p>');
});
it('can truncate html to 0 words, leaving first image tag & if alt text has a double quote', function () {
var html = '<p><img src="example.jpg" alt="A double quote is \'" />' +
'Hello <strong>World! It\'s me!</strong></p>',
rendered = (
helpers.content
.call(
{html: html},
{hash: {words: '0'}}
)
);
should.exist(rendered);
rendered.string.should.equal('<p><img src="example.jpg" alt="A double quote is \'" /></p>');
});
it('can truncate html to 0 words, leaving first image tag if it contains > & <', function () {
var html = '<p><img src="examp>><><>le.png"></p>',
rendered = (
helpers.content
.call(
{html: html},
{hash: {words: '0'}}
)
);
should.exist(rendered);
rendered.string.should.equal('<p><img src="examp>><><>le.png"></p>');
});
it('can truncate html to 0 words, leaving first two image tags', function () {
var html = '<p><img src="example.png"><img src="example.png">Hi<img src="example.png"></p>',
rendered = (
helpers.content
.call(
{html: html},
{hash: {words: '0'}}
)
);
should.exist(rendered);
rendered.string.should.equal('<p><img src="example.png"><img src="example.png"></p>');
});
it('can truncate html to 0 words, removing image if text comes first', function () {
var html = '<p><a>Bli<a><a><img src="example.png"></a></a>Blob</a></p>',
rendered = (
helpers.content
.call(
{html: html},
{hash: {words: '0'}}
)
);
should.exist(rendered);
rendered.string.should.equal('<p><a></a></p>');
});
it('can truncate html to 0 words, leaving video tag', function () {
var html = '<p><video><source src="movie.mp4"><source src="movie.ogg"></video></p>',
rendered = (
helpers.content
.call(
{html: html},
{hash: {words: '0'}}
)
);
should.exist(rendered);
rendered.string.should.equal('<p><video><source src="movie.mp4"><source src="movie.ogg"></video></p>');
rendered.string.should.equal('');
});
it('can truncate html by character', function () {