From 55e61666185226d73a0c50a3815309879564ed60 Mon Sep 17 00:00:00 2001 From: Chris Raible Date: Thu, 5 Sep 2024 16:29:16 -0700 Subject: [PATCH] Removed retries from batch sending tests (#20934) no issue - These retries were added a while ago when these tests were flaking in CI, but this only serves to cover up any potential problems with these tests or the code they are testing - Ran these tests in CI three times in a row without them failing, so I don't think the retries are necessary --- .../integration/services/email-service/batch-sending.test.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/ghost/core/test/integration/services/email-service/batch-sending.test.js b/ghost/core/test/integration/services/email-service/batch-sending.test.js index 6825bc4f6d..9e3fc96f47 100644 --- a/ghost/core/test/integration/services/email-service/batch-sending.test.js +++ b/ghost/core/test/integration/services/email-service/batch-sending.test.js @@ -170,7 +170,6 @@ describe('Batch sending tests', function () { }); it('Protects the email job from being run multiple times at the same time', async function () { - this.retries(1); // Prepare a post and email model const {emailModel} = await sendEmail(agent); @@ -679,7 +678,6 @@ describe('Batch sending tests', function () { }); it('Does replace with and without fallback in both plaintext and html for member with name', async function () { - this.retries(1); // Create a new member without a first_name await models.Member.add({ name: 'Simon Tester', @@ -855,7 +853,6 @@ describe('Batch sending tests', function () { }); it('Shows subscription details box for free members', async function () { - this.retries(1); // Create a new member without a first_name await models.Member.add({ email: 'subscription-box-1@example.com',