From 541fb4d2db2f1f99cf701aa48ef5555390546049 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Tue, 6 Jul 2021 10:15:32 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20potential=20for=20partia?= =?UTF-8?q?l=20content=20re-generation=20in=204.0=20migrations=20(#13120)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit no issue - incorrect syntax was used in the error handlers inside of the `for` loop, by using `return` when logging the whole for-loop was aborted whereas we want to log and continue processing the rest of the items --- .../migrations/versions/4.0/23-regenerate-posts-html.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/core/server/data/migrations/versions/4.0/23-regenerate-posts-html.js b/core/server/data/migrations/versions/4.0/23-regenerate-posts-html.js index d4aa7d44c2..2ec714c7a5 100644 --- a/core/server/data/migrations/versions/4.0/23-regenerate-posts-html.js +++ b/core/server/data/migrations/versions/4.0/23-regenerate-posts-html.js @@ -30,10 +30,12 @@ module.exports = createIrreversibleMigration(async (knex) => { mobiledoc = JSON.parse(post.mobiledoc || null); if (!mobiledoc) { - return logging.warn(`No mobiledoc for ${id}. Skipping.`); + logging.warn(`No mobiledoc for ${id}. Skipping.`); + continue; } } catch (err) { - return logging.warn(`Invalid JSON structure for ${id}. Skipping`); + logging.warn(`Invalid JSON structure for ${id}. Skipping`); + continue; } const html = mobiledocLib.mobiledocHtmlRenderer.render(mobiledoc);