Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Rearranged the markup so the empty state shows ok without pie chart

Browse source 
refs https://github.com/orgs/TryGhost/projects/60
This commit is contained in:
James Morris 2022-10-24 11:03:54 +01:00
parent fda12d103a
commit 53e20f30ae
1 changed files with 42 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

81
ghost/admin/app/components/posts/post-activity-feed.hbs
View file

@ -1,16 +1,18 @@
<div class="gh-post-activity-feed">
<div class="gh-dashboard-list-body">
{{#let (activity-feed-fetcher filter=(members-event-filter post=@postId excludedEvents=this.getEventTypes) pageSize=this.pageSize) as |eventsFetcher|}}
{{#if eventsFetcher.isError}}
{{#let (activity-feed-fetcher filter=(members-event-filter post=@postId excludedEvents=this.getEventTypes) pageSize=this.pageSize) as |eventsFetcher|}}
{{#if eventsFetcher.isError}}
<div class="gh-dashboard-list-body">
<div class="gh-dashboard-list-error">
<p>There was an error loading events</p>
{{#if eventsFetcher.errorMessage}}
<code>{{eventsFetcher.errorMessage}}</code>
{{/if}}
</div>
{{/if}}
</div>
{{/if}}
{{#if (and (not eventsFetcher.data) (not eventsFetcher.isLoading))}}
{{#if (and (not eventsFetcher.data) (not eventsFetcher.isLoading))}}
<div class="gh-dashboard-list-body">
<div class="gh-post-activity-feed-empty">
<div class="attribution-list-empty">
{{#if (eq this.eventType "sent")}}
@ -36,7 +38,9 @@
{{/if}}
</div>
</div>
{{else}}
</div>
{{else}}
<div class="gh-dashboard-list-body">
{{#each eventsFetcher.data as |event|}}
{{#let (parse-member-event event) as |parsedEvent|}}
<div class="gh-dashboard-list-item">
@ -107,39 +111,38 @@
</LinkTo>
{{/if}}
</div>
</div>
{{#if (eq @eventType 'feedback')}}
<div
class="gh-feedback-events-feed"
id="gh-feedback-events-feed"
{{on "mouseleave" this.onMouseleave}}
>
<div class="gh-feedback-events-feed-container">
<Posts::FeedbackEventsChart
@data={{@data}}
/>
</div>
<div
class="gh-feedback-events-tooltip"
id="gh-feedback-events-tooltip"
{{did-insert this.onTooltipInsert}}
>
<div id="gh-feedback-events-tooltip-body">
</div>
<div class="gh-feedback-events-tooltip-footer" id="gh-feedback-events-tooltip-footer">
<Posts::FeedbackEventsTooltipTemplate
@positiveLink={{@positiveLink}}
@negativeLink={{@negativeLink}}
/>
</div>
</div>
</div>
{{/if}}
{{/let}}
</div>
{{#if (eq @eventType 'feedback')}}
<div
class="gh-feedback-events-feed"
id="gh-feedback-events-feed"
{{on "mouseleave" this.onMouseleave}}
>
<div class="gh-feedback-events-feed-container">
<Posts::FeedbackEventsChart
@data={{@data}}
/>
</div>
<div
class="gh-feedback-events-tooltip"
id="gh-feedback-events-tooltip"
{{did-insert this.onTooltipInsert}}
>
<div id="gh-feedback-events-tooltip-body">
</div>
<div class="gh-feedback-events-tooltip-footer" id="gh-feedback-events-tooltip-footer">
<Posts::FeedbackEventsTooltipTemplate
@positiveLink={{@positiveLink}}
@negativeLink={{@negativeLink}}
/>
</div>
</div>
</div>
{{/if}}
{{/if}}
{{/let}}
</div>