Removed unused code from <GhMembersPaymentSettings>

no issue

- code relating to "portal settings" and "leave settings" modals was unused, presumably left over from settings re-jig copy and paste

ghost/admin/app/components/gh-members-payments-setting.hbs

@@ -288,20 +288,4 @@
         @confirm={{action "disconnectStripeConnectIntegration"}}
         @close={{action "closeDisconnectStripeModal"}}
         @modifier="action wide" />
-{{/if}}
-
-{{#if this.showPortalSettings}}
-    <GhFullscreenModal @modal="portal-settings"
-        @model={{hash
-            openStripeSettings=(action "openStripeSettings")
-        }}
-        @close={{action "closePortalSettings"}}
-        @modifier="full-overlay portal-settings" />
-{{/if}}
-
-{{#if this.showLeaveSettingsModal}}
-    <GhFullscreenModal @modal="leave-settings"
-        @confirm={{action "leavePortalSettings"}}
-        @close={{action "closeLeaveSettingsModal"}}
-        @modifier="action wide" />
 {{/if}}

ghost/admin/app/components/gh-members-payments-setting.js

@@ -19,7 +19,6 @@ export default Component.extend({
     stripePlanInvalidAmount: false,
     _scratchStripeYearlyAmount: null,
     _scratchStripeMonthlyAmount: null,
-    showLeaveSettingsModal: false,
 
     // passed in actions
     setStripeConnectIntegrationTokenSetting() {},
@@ -38,8 +37,6 @@ export default Component.extend({
     stripeConnectAccountName: reads('settings.stripeConnectDisplayName'),
     stripeConnectLivemode: reads('settings.stripeConnectLivemode'),
 
-    portalSettingsBorderColor: reads('settings.accentColor'),
-
     selectedCurrency: computed('stripePlans.monthly.currency', function () {
         return this.get('currencies').findBy('value', this.get('stripePlans.monthly.currency')) || this.get('topCurrencies').findBy('value', this.get('stripePlans.monthly.currency'));
     }),
@@ -106,15 +103,6 @@ export default Component.extend({
     },
 
     actions: {
-        closePortalSettings() {
-            const changedAttributes = this.settings.changedAttributes();
-            if (changedAttributes && Object.keys(changedAttributes).length > 0) {
-                this.set('showLeaveSettingsModal', true);
-            } else {
-                this.set('showPortalSettings', false);
-            }
-        },
-
         setDefaultContentVisibility(value) {
             this.setDefaultContentVisibility(value);
         },
@@ -184,16 +172,6 @@ export default Component.extend({
             this.disconnectStripeConnectIntegration.perform();
         },
 
-        closeLeaveSettingsModal() {
-            this.set('showLeaveSettingsModal', false);
-        },
-
-        leavePortalSettings() {
-            this.settings.rollbackAttributes();
-            this.set('showPortalSettings', false);
-            this.set('showLeaveSettingsModal', false);
-        },
-
         openStripeSettings() {
             this.set('membersStripeOpen', true);
         }

ghost/admin/app/templates/settings/members-payments.hbs

@@ -21,7 +21,6 @@
         {{#if this.session.user.isOwner}}
         <div class="gh-setting-liquid-section">
             <GhMembersPaymentsSetting
-                @settings={{this.settings}}
                 @setDefaultContentVisibility={{action "setDefaultContentVisibility"}}
                 @setStripeConnectIntegrationTokenSetting={{action "setStripeConnectIntegrationTokenSetting"}}
             />