Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Fixed flaky publishing browser tests (#20935)

Browse source 
no issue

- These two tests were relying on the ordering of the posts in the posts
list, which can vary when running the test suite all together (as we do
in CI), since multiple tests can be running and creating/deleting posts
in parallel.
- This commit navigates directly to the post's URL to avoid this
problem.
This commit is contained in:
Chris Raible 2024-10-03 10:06:28 -07:00 • committed by GitHub
parent b125a25dfc
commit 52ac218867
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
ghost/core/test/e2e-browser/admin/publishing.spec.js
View file

@ -312,6 +312,7 @@ test.describe('Publishing', () => {
const date = DateTime.now();
await createPostDraft(adminPage, {title: 'Testing publish update', body: 'This is the initial published text.'});
const editorUrl = await adminPage.url();
await publishPost(adminPage);
const frontendPage = await openPublishedPostBookmark(adminPage);
await closePublishFlow(adminPage);
@ -323,7 +324,7 @@ test.describe('Publishing', () => {
await expect(publishedHeader).toContainText(date.toFormat('LLL d, yyyy'));
// add some extra text to the post
await adminPage.locator('li[data-test-post-id]').first().click();
await adminPage.goto(editorUrl);
await adminPage.locator('[data-kg="editor"]').first().click();
await adminPage.waitForTimeout(500);
await adminPage.keyboard.type(' This is some updated text.');
@ -455,6 +456,8 @@ test.describe('Publishing', () => {
await sharedPage.goto('/ghost');
await createPostDraft(sharedPage, postData);
const editorUrl = await sharedPage.url();
// Schedule far in the future
await publishPost(sharedPage, {date: '2050-01-01', time: '10:09'});
await closePublishFlow(sharedPage);
@ -469,7 +472,7 @@ test.describe('Publishing', () => {
await checkPostNotPublished(testsharedPage, postData);
// Now unschedule this post
await sharedPage.locator('li[data-test-post-id]').first().click();
await sharedPage.goto(editorUrl);
await sharedPage.locator('[data-test-button="update-flow"]').first().click();
await sharedPage.locator('[data-test-button="revert-to-draft"]').click();