Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-27 22:49:56 -05:00
Code Issues Activity

Updated class names for Share modal (#19966)

Browse source 
fixes IPC-134

Some class names in the share modal (onboarding) were not in line with
how we define our classes at Ghost.
This commit is contained in:
Daniël van der Winden 2024-04-02 13:48:17 +02:00 • committed by GitHub
parent a263877aa5
commit 50dceb23ff
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 41 additions and 41 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
ghost/admin/app/components/dashboard/onboarding/share-modal.hbs
View file

@ -4,19 +4,19 @@
</header> </header>
<button type="button" class="close" title="Close" {{on "click" @close}}>{{svg-jar "close"}}<span class="hidden">Close</span></button> <button type="button" class="close" title="Close" {{on "click" @close}}>{{svg-jar "close"}}<span class="hidden">Close</span></button>
<div class="share-card-container"> <div class="gh-share-card-container">
{{#let (get-setting "coverImage") as |imageUrl|}} {{#let (get-setting "coverImage") as |imageUrl|}}
{{#if imageUrl}} {{#if imageUrl}}
<div class="share-card-image"> <div class="gh-share-card-image">
<img src={{imageUrl}} alt="" role="presentation" /> <img src={{imageUrl}} alt="" role="presentation" />
</div> </div>
{{else}} {{else}}
<div class="share-card-image placeholder">{{svg-jar "picture"}}</div> <div class="gh-share-card-image gh-cover-placeholder">{{svg-jar "picture"}}</div>
{{/if}} {{/if}}
<div class="share-card-content"> <div class="gh-share-card-content">
<div class="share-card-title">{{get-setting "title"}}</div> <div class="gh-share-card-title">{{get-setting "title"}}</div>
<div class="share-card-description"> <div class="gh-share-card-description">
{{get-setting "description"}} {{get-setting "description"}}
</div> </div>
</div> </div>
@ -24,9 +24,9 @@
</div> </div>
<span class="tip">Set your publication's cover image and description in <LinkTo @route="settings-x.settings-x" @model="design/edit?ref=setup">Design settings</LinkTo>.</span> <span class="gh-tip">Set your publication's cover image and description in <LinkTo @route="settings-x.settings-x" @model="design/edit?ref=setup">Design settings</LinkTo>.</span>
<div class="copy-publication-link"> <div class="gh-copy-publication-link">
<span>{{this.config.blogUrl}}</span> <span>{{this.config.blogUrl}}</span>
<GhTaskButton <GhTaskButton
data-test-button="copy-share-link" data-test-button="copy-share-link"
@ -38,9 +38,9 @@
/> />
</div> </div>
<ul class="share-links"> <ul class="gh-share-links">
<li> <li>
<a href="https://twitter.com/intent/tweet?url={{this.encodedUrl}}" target="_blank" rel="noopener noreferrer" class="share-link" title="Share your publication on X"> <a href="https://twitter.com/intent/tweet?url={{this.encodedUrl}}" target="_blank" rel="noopener noreferrer" class="gh-share-link" title="Share your publication on X">
<span>{{svg-jar "social-x"}}</span> <span>{{svg-jar "social-x"}}</span>
</a> </a>
</li> </li>

10
ghost/admin/app/styles/app-dark.css
View file

@ -1392,24 +1392,24 @@ Onboarding checklist */
/* --------------------------------- /* ---------------------------------
Onboarding checklist: Share publication modal */ Onboarding checklist: Share publication modal */
.share-card-container { .gh-share-card-container {
border: 1px solid #394047; border: 1px solid #394047;
} }
.copy-publication-link { .gh-copy-publication-link {
background: #394047; background: #394047;
border: none; border: none;
} }
.copy-publication-link:hover { .gh-copy-publication-link:hover {
border: none; border: none;
opacity: .8; opacity: .8;
} }
.share-links li a { .gh-share-links li a {
border: 1px solid #394047; border: 1px solid #394047;
} }
.share-links li a:hover { .gh-share-links li a:hover {
background: #394047; background: #394047;
} }

52
ghost/admin/app/styles/layouts/dashboard.css
View file

@ -3004,7 +3004,7 @@ Onboarding checklist */
/* --------------------------------- /* ---------------------------------
Share publication modal */ Share publication modal */
.share-card-container { .gh-share-card-container {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
align-items: center; align-items: center;
@ -3015,18 +3015,18 @@ Share publication modal */
transition: all .3s ease-in-out; transition: all .3s ease-in-out;
} }
.share-card-image { .gh-share-card-image {
max-height: 196px; max-height: 196px;
} }
.share-card-image img { .gh-share-card-image img {
border-radius: 6px 6px 0 0; border-radius: 6px 6px 0 0;
object-fit: cover; object-fit: cover;
width: 484px; width: 484px;
height: 196px; height: 196px;
} }
.placeholder { .gh-cover-placeholder {
width: 100%; width: 100%;
height: 196px; height: 196px;
border-radius: 6px 6px 0 0; border-radius: 6px 6px 0 0;
@ -3036,23 +3036,23 @@ Share publication modal */
background: var(--whitegrey); background: var(--whitegrey);
} }
.placeholder svg { .gh-cover-placeholder svg {
width: 40px; width: 40px;
height: 40px; height: 40px;
stroke: var(--lightgrey); stroke: var(--lightgrey);
} }
.share-card-content { .gh-share-card-content {
padding: 24px; padding: 24px;
width: 100%; width: 100%;
} }
.share-card-title { .gh-share-card-title {
font-size: 1.7rem; font-size: 1.7rem;
font-weight: 600; font-weight: 600;
} }
.copy-publication-link { .gh-copy-publication-link {
display: flex; display: flex;
align-items: center; align-items: center;
justify-content: space-between; justify-content: space-between;
@ -3067,21 +3067,21 @@ Share publication modal */
transition: all .3s ease-in-out; transition: all .3s ease-in-out;
} }
.copy-publication-link:hover { .gh-copy-publication-link:hover {
border: 1px solid var(--lightgrey); border: 1px solid var(--lightgrey);
} }
.copy-publication-link .gh-btn-icon { .gh-copy-publication-link .gh-btn-icon {
font-weight: 600; font-weight: 600;
} }
.copy-publication-link .gh-share-link-success { .gh-copy-publication-link .gh-share-link-success {
color: var(--green); color: var(--green);
font-size: 1.5rem; font-size: 1.5rem;
font-weight: 600; font-weight: 600;
} }
.share-links { .gh-share-links {
list-style: none; list-style: none;
padding: 0; padding: 0;
margin: 16px 0 0 0; margin: 16px 0 0 0;
@ -3089,7 +3089,7 @@ Share publication modal */
flex-direction: row; flex-direction: row;
} }
.share-links li { .gh-share-links li {
font-size: 1.5rem; font-size: 1.5rem;
font-weight: 600; font-weight: 600;
color: var(--darkgrey); color: var(--darkgrey);
@ -3099,11 +3099,11 @@ Share publication modal */
vertical-align: middle; vertical-align: middle;
} }
.share-links li:last-child { .gh-share-links li:last-child {
margin: 0; margin: 0;
} }
.share-links li a { .gh-share-links li a {
display: block; display: block;
padding: 20px 0; padding: 20px 0;
text-align: center; text-align: center;
@ -3112,44 +3112,44 @@ Share publication modal */
transition: all .3s ease-in-out; transition: all .3s ease-in-out;
} }
.share-links li a:hover { .gh-share-links li a:hover {
box-shadow: 0 2px 4px rgb(0 0 0 / 7%); box-shadow: 0 2px 4px rgb(0 0 0 / 7%);
} }
.share-links li span { .gh-share-links li span {
vertical-align: middle; vertical-align: middle;
height: 20px; height: 20px;
display: block; display: block;
} }
.share-links li a span svg { .gh-share-links li a span svg {
width: 20px; width: 20px;
height: 20px; height: 20px;
fill: var(--midgrey); fill: var(--midgrey);
} }
.share-links svg path.social-facebook_svg__fb { .gh-share-links svg path.social-facebook_svg__fb {
fill: var(--midgrey); fill: var(--midgrey);
} }
.share-links svg path.social-linkedin_svg__linkedin { .gh-share-links svg path.social-linkedin_svg__linkedin {
fill: var(--midgrey); fill: var(--midgrey);
} }
.share-links a:hover svg path.social-facebook_svg__fb { .gh-share-links a:hover svg path.social-facebook_svg__fb {
fill: #1977f3; fill: #1977f3;
} }
.share-links a:hover svg path.social-linkedin_svg__linkedin { .gh-share-links a:hover svg path.social-linkedin_svg__linkedin {
fill: #007ebb; fill: #007ebb;
} }
.share-links a:hover svg path.social-x_svg__x { .gh-share-links a:hover svg path.social-x_svg__x {
fill: var(--black); fill: var(--black);
} }
span.tip { span.gh-tip {
font-size: 1.4rem; font-size: 1.4rem;
font-weight: 400; font-weight: 400;
line-height: 1.5; line-height: 1.5;
@ -3160,11 +3160,11 @@ span.tip {
display: block; display: block;
} }
span.tip a { span.gh-tip a {
text-decoration: underline; text-decoration: underline;
color: var(--midgrey); color: var(--midgrey);
} }
span.tip a:hover { span.gh-tip a:hover {
color: var(--darkgrey); color: var(--darkgrey);
} }