Updated package.json

no issue

- Since yarn used to be able to get and used dependencies from all over
  the monorepo, pnpm had issues resolving dependencies that were often
resolved globally. In this case, we mostly used Typescript globally,
which caused errors in typescript building properly and type
declerations not resolving.

.npmrc

@@ -1,5 +1,3 @@
 link-workspace-packages=true
 registry=http://0.0.0.0:4873/ # scotland problem, links to verdaccio due to slow internet
-public-hoist-pattern[]=*types*
-public-hoist-pattern[]=!@types/react/*
-public-hoist-pattern[]=!@types/react-dom/*
+hoist-pattern[]=typescript

apps/admin-x-design-system/tsconfig.json

@@ -5,6 +5,9 @@
       "module": "ESNext",
       "skipLibCheck": true,
       "types": ["vite/client"],
+      "paths": {
+        "react": ["./node_modules/@types/react"]
+      },
 
       /* Bundler mode */
       "moduleResolution": "bundler",
@@ -17,9 +20,6 @@
       "noUnusedLocals": true,
       "noUnusedParameters": true,
       "noFallthroughCasesInSwitch": true,
-      "paths": {
-        "react": ["./node_modules/@types/react"]
-      }
     },
     "include": ["src"],
     "references": [{ "path": "./tsconfig.node.json" }]

ghost/admin/package.json

@@ -178,6 +178,7 @@
   "dependencies": {
     "i18n-iso-countries": "7.12.0",
     "jose": "4.15.9",
+    "lodash": "4.17.21",
     "path-browserify": "1.0.1",
     "webpack": "5.95.0"
   },

ghost/bookshelf-repository/package.json

@@ -20,10 +20,11 @@
     "build"
   ],
   "devDependencies": {
+    "@tryghost/nql": "0.12.5",
     "c8": "7.14.0",
     "mocha": "10.2.0",
     "sinon": "15.2.0",
-    "@tryghost/nql": "0.12.5"
+    "typescript": "^5.6.3"
   },
   "dependencies": {
     "@tryghost/mongo-utils": "0.6.2",

ghost/collections/package.json

@@ -21,9 +21,12 @@
     ],
     "devDependencies": {
         "@tryghost/domain-events": "0.0.0",
+        "@types/knex": "^0.16.1",
+        "@types/lodash": "^4.17.10",
         "c8": "8.0.1",
         "mocha": "10.2.0",
-        "sinon": "15.2.0"
+        "sinon": "15.2.0",
+        "typescript": "^5.6.3"
     },
     "dependencies": {
         "@tryghost/debug": "0.1.32",
@@ -35,6 +38,7 @@
         "@tryghost/post-events": "0.0.0",
         "@tryghost/tpl": "0.1.32",
         "bson-objectid": "2.0.4",
+        "knex": "2.4.2",
         "lodash": "4.17.21"
     },
     "c8": {

ghost/donations/package.json

@@ -22,11 +22,12 @@
     "build"
   ],
   "devDependencies": {
+    "@types/mocha": "10.0.1",
+    "@types/node": "20.14.8",
     "c8": "8.0.1",
     "mocha": "10.2.0",
     "sinon": "15.2.0",
     "ts-node": "10.9.2",
     "typescript": "5.4.5"
-  },
-  "dependencies": {}
+  }
 }

ghost/donations/tsconfig.json

@@ -4,6 +4,8 @@
     "src/**/*"
   ],
   "compilerOptions": {
-    "outDir": "build"
+    "outDir": "build",
+    "types": ["node", "mocha"],
+    "typeRoots": ["./node_modules/@types"]
   }
 }

ghost/email-addresses/package.json

@@ -22,6 +22,7 @@
     "build"
   ],
   "devDependencies": {
+    "@types/nodemailer": "6.4.15",
     "c8": "8.0.1",
     "mocha": "10.2.0",
     "sinon": "15.2.0",

ghost/ghost/package.json

@@ -21,6 +21,7 @@
   ],
   "devDependencies": {
     "@nestjs/testing": "10.3.10",
+    "@types/express": "4.17.21",
     "@types/node": "20.14.8",
     "@types/sinon": "^17.0.3",
     "@types/supertest": "^6.0.2",

ghost/in-memory-repository/package.json

@@ -22,7 +22,8 @@
   "devDependencies": {
     "c8": "8.0.1",
     "mocha": "10.2.0",
-    "sinon": "15.2.0"
+    "sinon": "15.2.0",
+    "typescript": "^5.6.3"
   },
   "dependencies": {
     "@tryghost/nql": "0.12.5"

ghost/mail-events/package.json

@@ -22,7 +22,8 @@
     "devDependencies": {
         "c8": "8.0.1",
         "mocha": "10.2.0",
-        "sinon": "15.2.0"
+        "sinon": "15.2.0",
+        "typescript": "^5.6.3"
     },
     "dependencies": {
         "@tryghost/errors": "1.3.5",

ghost/model-to-domain-event-interceptor/package.json

@@ -7,13 +7,13 @@
     "main": "build/index.js",
     "types": "build/index.d.ts",
     "scripts": {
-        "build": "yarn build:ts",
+        "build": "pnpm build:ts",
         "build:ts": "tsc",
         "test:unit": "NODE_ENV=testing c8 --src src --all --check-coverage --100 --reporter text --reporter cobertura -- mocha --reporter dot -r ts-node/register './test/**/*.test.ts'",
-        "test": "yarn test:types && yarn test:unit",
+        "test": "pnpm test:types && pnpm test:unit",
         "test:types": "tsc --noEmit",
         "lint:code": "eslint src/ --ext .ts --cache",
-        "lint": "yarn lint:code && yarn lint:test",
+        "lint": "pnpm lint:code && pnpm lint:test",
         "lint:test": "eslint -c test/.eslintrc.js test/ --ext .ts --cache"
     },
     "files": [

ghost/nql-filter-expansions/package.json

@@ -22,7 +22,7 @@
   "devDependencies": {
     "c8": "8.0.1",
     "mocha": "10.2.0",
-    "sinon": "15.2.0"
-  },
-  "dependencies": {}
+    "sinon": "15.2.0",
+    "typescript": "^5.6.3"
+  }
 }

ghost/post-events/package.json

@@ -23,7 +23,7 @@
   "devDependencies": {
     "c8": "8.0.1",
     "mocha": "10.2.0",
-    "sinon": "15.2.0"
-  },
-  "dependencies": {}
+    "sinon": "15.2.0",
+    "typescript": "^5.6.3"
+  }
 }

ghost/post-revisions/package.json

@@ -22,7 +22,7 @@
   "devDependencies": {
     "c8": "8.0.1",
     "mocha": "10.2.0",
-    "sinon": "15.2.0"
-  },
-  "dependencies": {}
+    "sinon": "15.2.0",
+    "typescript": "^5.6.3"
+  }
 }

ghost/recommendations/package.json

@@ -30,10 +30,12 @@
     "typescript": "5.4.5"
   },
   "dependencies": {
-    "@tryghost/tpl": "0.1.32",
+    "@tryghost/bookshelf-repository": "0.0.0",
     "@tryghost/errors": "1.3.5",
     "@tryghost/in-memory-repository": "0.0.0",
-    "@tryghost/bookshelf-repository": "0.0.0",
-    "@tryghost/logging": "2.4.18"
+    "@tryghost/logging": "2.4.18",
+    "@tryghost/tpl": "0.1.32",
+    "bson-objectid": "2.0.4",
+    "knex": "2.4.2"
   }
 }

package.json

@@ -7,8 +7,7 @@
   "author": "Ghost Foundation",
   "license": "MIT",
   "workspaces": [
-    "ghost/*",
-    "apps/*"
+    "*"
   ],
   "monorepo": {
     "public": false,
@@ -113,6 +112,8 @@
   },
   "devDependencies": {
     "@actions/core": "1.10.1",
+    "@types/mocha": "10.0.1",
+    "@types/node": "20.14.8",
     "chalk": "4.1.2",
     "concurrently": "8.2.2",
     "eslint": "8.44.0",
@@ -124,6 +125,6 @@
     "nx": "19.8.4",
     "rimraf": "5.0.10",
     "ts-node": "10.9.2",
-    "typescript": "5.4.5"
+    "typescript": "5.6.3"
   }
 }

pnpm-workspace.yaml

@@ -1,3 +1,2 @@
 packages:
-  - 'apps/*'
-  - 'ghost/*'
+  - 'ghost/*/**'