Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

Moved default post access from Payments to Access screen (#1879)

Browse source 
refs https://github.com/TryGhost/Team/issues/579

- updated access section on Payments screen to only show when not running developer experiments
- added default post access settings to Access screen

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>
This commit is contained in:
Sanne de Vries 2021-04-14 20:02:36 +02:00 • committed by GitHub
parent f92532d51c
commit 4f10e611b0
3 changed files with 63 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/components/gh-members-payments-setting.hbs
View file

@ -216,6 +216,7 @@
</section>
</div>
{{#unless (enable-developer-experiments)}}
<div class="gh-main-section">
<h4 class="gh-main-section-header small bn">Access</h4>
<section class="gh-expandable">
@ -277,6 +278,7 @@
</div>
</section>
</div>
{{/unless}}
{{#if this.showDisconnectStripeConnectModal}}
<GhFullscreenModal @modal="disconnect-stripe"

11
ghost/admin/app/controllers/settings/members-access.js
View file

@ -8,6 +8,7 @@ export default class MembersAccessController extends Controller {
@service settings;
@tracked showLeaveSettingsModal = false;
@tracked membersPostAccessOpen = false;
leaveRoute(transition) {
if (this.settings.get('hasDirtyAttributes')) {
@ -30,6 +31,16 @@ export default class MembersAccessController extends Controller {
this.leaveSettingsTransition = null;
}
@action
toggleMembersPostAccess() {
this.membersPostAccessOpen = !this.membersPostAccessOpen;
}
@action
setDefaultContentVisibility(value) {
this.settings.set('defaultContentVisibility', value);
}
@task({drop: true})
*saveSettingsTask() {
return yield this.settings.save();

51
ghost/admin/app/templates/settings/members-access.hbs
View file

@ -6,7 +6,8 @@
Access
</h2>
<section class="view-actions">
<GhTaskButton @buttonText="Save settings"
<GhTaskButton
@buttonText="Save settings"
@task={{this.saveSettingsTask}}
@successText="Saved"
@runningText="Saving"
@ -17,7 +18,55 @@
</GhCanvasHeader>
<section class="view-container settings-debug">
<section class="gh-expandable">
<div class="gh-expandable-block">
<div class="gh-expandable-header">
<div>
<h4 class="gh-expandable-title">Default post access</h4>
<p class="gh-expandable-description">When a new post is created, who should have access to it?</p>
</div>
<button type="button" class="gh-btn" {{on "click" this.toggleMembersPostAccess}} data-test-toggle="members-post-access"><span>{{if this.membersPostAccessOpen "Close" "Expand"}}</span></button>
</div>
<div class="gh-expandable-content">
{{#liquid-if this.membersPostAccessOpen}}
<div class="flex flex-column w-50 flex">
<div
class="gh-radio {{if (eq this.settings.defaultContentVisibility "public") "active"}}"
{{on "click" (fn this.setDefaultContentVisibility "public")}}
>
<div class="gh-radio-button"></div>
<div class="gh-radio-content">
<div class="gh-radio-label">Public<br>
<small class="midgrey">All site visitors to your site, no login required</small></div>
</div>
</div>
<div
class="gh-radio {{if (eq this.settings.defaultContentVisibility "members") "active"}}"
{{on "click" (fn this.setDefaultContentVisibility "members")}}
>
<div class="gh-radio-button"></div>
<div class="gh-radio-content">
<div class="gh-radio-label">Members only<br>
<small class="midgrey">All logged-in members</small></div>
</div>
</div>
<div
class="gh-radio {{if (eq this.settings.defaultContentVisibility "paid") "active"}}"
{{on "click" (fn this.setDefaultContentVisibility "paid")}}
>
<div class="gh-radio-button"></div>
<div class="gh-radio-content">
<div class="gh-radio-label">Paid-members only<br>
<small class="midgrey">Only logged-in members with an active Stripe subscription</small></div>
</div>
</div>
</div>
{{/liquid-if}}
</div>
</div>
</section>
</section>
{{#if this.showLeaveSettingsModal}}