From 4e6051a5bd2645c0585f226c34bbc9aeb53e9407 Mon Sep 17 00:00:00 2001 From: Rishabh Date: Wed, 19 May 2021 20:19:39 +0530 Subject: [PATCH] Fixed portal plans change not triggering recompute no refs Portal plan settings are updated on the membership page when the plans are changed, but its not reflected in Portal settings because we were not updating the array the ember way. --- ghost/admin/app/controllers/settings/membership.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ghost/admin/app/controllers/settings/membership.js b/ghost/admin/app/controllers/settings/membership.js index 629818be92..b769994dd0 100644 --- a/ghost/admin/app/controllers/settings/membership.js +++ b/ghost/admin/app/controllers/settings/membership.js @@ -314,12 +314,12 @@ export default class MembersAccessController extends Controller { const currentYearlyPriceId = this.settings.get('membersYearlyPriceId'); if (portalPlans.includes(currentMontlyPriceId)) { portalPlans = portalPlans.filter(priceId => priceId !== currentMontlyPriceId); - portalPlans.push(monthlyPriceId); + portalPlans.pushObject(monthlyPriceId); } if (portalPlans.includes(currentYearlyPriceId)) { portalPlans = portalPlans.filter(priceId => priceId !== currentYearlyPriceId); - portalPlans.push(yearlyPriceId); + portalPlans.pushObject(yearlyPriceId); } this.settings.set('portalPlans', portalPlans); }