Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

Enable Escape key to close tag suggestion popup

Browse source 
closes #1893
- Checking the contents of search term after evaluating the keycode caused the suggestion box to be hidden and immediately reshown
- Moving the if/else to the top of the function enables us to fix the issue without complicating the suggestion update logic
This commit is contained in:
Kate von Roeder 2014-01-14 13:17:06 -08:00
parent c82d2eadba
commit 4dbf57f2d3
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
core/client/views/editor-tag-widget.js
View file

@ -134,6 +134,12 @@
var $target = $(e.currentTarget), var $target = $(e.currentTarget),
searchTerm = $.trim($target.val()); searchTerm = $.trim($target.val());
if (searchTerm) {
this.showSuggestions($target, searchTerm);
} else {
this.$suggestions.hide();
}
if (e.keyCode === this.keys.UP) { if (e.keyCode === this.keys.UP) {
e.preventDefault(); e.preventDefault();
if (this.$suggestions.is(":visible")) { if (this.$suggestions.is(":visible")) {
@ -159,12 +165,6 @@
if (e.keyCode === this.keys.UP || e.keyCode === this.keys.DOWN) { if (e.keyCode === this.keys.UP || e.keyCode === this.keys.DOWN) {
return false; return false;
} }
if (searchTerm) {
this.showSuggestions($target, searchTerm);
} else {
this.$suggestions.hide();
}
}, },
handleKeydown: function (e) { handleKeydown: function (e) {