From 4d26c50e0b4e6d57dba577eed215b4ac22ff8f2c Mon Sep 17 00:00:00 2001
From: Naz <hi@nazavo.com>
Date: Mon, 31 Oct 2022 16:14:38 +0800
Subject: [PATCH] Fixed data type of hasStripeData in member importer

refs https://github.com/TryGhost/Team/issues/1076

- What appeared to be a "boolean" by nature and name, the hasStripeData was holding a result of "find" method - and object or an undefined value
- Fixed the typing, to avoid ambiguity in the future
---
 ghost/members-importer/lib/importer.js       | 4 ++--
 ghost/members-importer/test/importer.test.js | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/ghost/members-importer/lib/importer.js b/ghost/members-importer/lib/importer.js
index 01ed454b03..01d6f9c0bc 100644
--- a/ghost/members-importer/lib/importer.js
+++ b/ghost/members-importer/lib/importer.js
@@ -86,9 +86,9 @@ module.exports = class MembersCSVImporter {
         const numberOfBatches = Math.ceil(rows.length / batchSize);
         const mappedCSV = membersCSV.unparse(rows, columns);
 
-        const hasStripeData = rows.find(function rowHasStripeData(row) {
+        const hasStripeData = !!(rows.find(function rowHasStripeData(row) {
             return !!row.stripe_customer_id || !!row.complimentary_plan;
-        });
+        }));
 
         await fs.writeFile(outputFilePath, mappedCSV);
 
diff --git a/ghost/members-importer/test/importer.test.js b/ghost/members-importer/test/importer.test.js
index fbd08c41ba..69fdf7365e 100644
--- a/ghost/members-importer/test/importer.test.js
+++ b/ghost/members-importer/test/importer.test.js
@@ -246,7 +246,7 @@ describe('Importer', function () {
 
             result.batches.should.equal(2);
             should.exist(result.metadata);
-
+            should.equal(result.metadata.hasStripeData, false);
             fsWriteSpy.calledOnce.should.be.true();
         });