Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity

Fixed generating fallback context unnecessarily

Browse source 
fixes https://github.com/TryGhost/Product/issues/4216

When generating page/post metadata, we generate a "context object" from
several meta helpers. In the event there is no context from the resource
type, we generate a fallback object.

However... we generate this fallback object no matter what.

Now, the fallback object is just 3x settingsCache.get, which should be
fast, but it's not. I've opened a separate issue for that: https://github.com/TryGhost/Product/issues/4217

In the mean time, we can switch this logic around to only do these calls
when we have no other context.

From testing, this allows for 10% more throughput on a post 🤯
This commit is contained in:
Daniel Lockyer 2023-11-29 10:29:32 +01:00 • committed by Daniel Lockyer
parent c0040e53ea
commit 4d029c4812
1 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
ghost/core/core/frontend/meta/context-object.js
View file

@ -2,15 +2,6 @@ const settingsCache = require('../../shared/settings-cache');
const _ = require('lodash');
function getContextObject(data, context) {
/**
* If the data object does not contain the requested context, we return the fallback object.
*/
const blog = {
cover_image: settingsCache.get('cover_image'),
twitter: settingsCache.get('twitter'),
facebook: settingsCache.get('facebook')
};
let chosenContext;
// @TODO: meta layer is very broken, it's really hard to understand what it's doing
@ -31,9 +22,13 @@ function getContextObject(data, context) {
chosenContext = data[context];
}
// Super fallback.
// If the data object does not contain the requested context, we return the fallback object.
if (!chosenContext) {
chosenContext = blog;
chosenContext = {
cover_image: settingsCache.get('cover_image'),
twitter: settingsCache.get('twitter'),
facebook: settingsCache.get('facebook')
};
}
return chosenContext;