Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Fixed error when deleting post (#19369)

Browse source 
closes https://github.com/TryGhost/Product/issues/4230

- deleting a post could cause React components to trigger save tasks during teardown which then threw errors because they attempt to set properties on a deleted model instance
- added checks to the `beforeSaveTask()` to abort if the post object has been deleted
This commit is contained in:
Kevin Ansfield 2023-12-13 17:45:23 +00:00 • committed by GitHub
parent b74a611fbd
commit 4ceb5dc16b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ghost/admin/app/controllers/lexical-editor.js
View file

@ -415,7 +415,11 @@ export default class LexicalEditorController extends Controller {
@action @action
handleFeatureImageCaptionBlur() { handleFeatureImageCaptionBlur() {
if (this.post?.isDraft) { if (!this.post || this.post.isDestroyed || this.post.isDestroying) {
return;
}
if (this.post.isDraft) {
this.autosaveTask.perform(); this.autosaveTask.perform();
} }
} }
@ -615,6 +619,10 @@ export default class LexicalEditorController extends Controller {
@task @task
*beforeSaveTask(options = {}) { *beforeSaveTask(options = {}) {
if (this.post?.isDestroyed || this.post?.isDestroying) {
return;
}
// ensure we remove any blank cards when performing a full save // ensure we remove any blank cards when performing a full save
if (!options.backgroundSave) { if (!options.backgroundSave) {
// TODO: not yet implemented in react editor // TODO: not yet implemented in react editor