Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Removed unused isPaymentConfigured method

Browse source 
refs https://github.com/TryGhost/Ghost/pull/11499

- Removed unused and confusin isPaymentConfigured because it was basing it's logic on old `isPaid` flag. Having it in the codebase was adding confusion.
- `isPaid` config flag still needs a proper cleanup with a migration etc.
- Added little post PR merge cleanup
This commit is contained in:
Nazar Gargol 2020-01-17 12:08:30 +07:00
parent 0030acf5a6
commit 4b57ad33b0
2 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/frontend/helpers/ghost_head.js
View file

@ -50,7 +50,7 @@ function getMembersHelper() {
const stripeSecretToken = stripePaymentProcessor.config.secret_token;
const stripePublicToken = stripePaymentProcessor.config.public_token;
var membersHelper = `<script defer src="${getAssetUrl('public/members.js')}"></script>`;
let membersHelper = `<script defer src="${getAssetUrl('public/members.js')}"></script>`;
if (!!stripeSecretToken && stripeSecretToken !== '' && !!stripePublicToken && stripePublicToken !== '') {
membersHelper += '<script src="https://js.stripe.com/v3/"></script>';
}

5
core/server/services/members/index.js
View file

@ -23,11 +23,6 @@ common.events.on('settings.edited', function updateSettingFromModel(settingModel
});
const membersService = {
isPaymentConfigured() {
const settings = settingsCache.get('members_subscription_settings');
return !!settings && settings.isPaid && settings.paymentProcessors.length !== 0;
},
contentGating: require('./content-gating'),
config: require('./config'),