From 4b40346ff46932a3f620ded388b4e9cbb9919b28 Mon Sep 17 00:00:00 2001 From: Kevin Ansfield Date: Tue, 21 Jan 2020 17:45:19 +0000 Subject: [PATCH] Cleaned up unused code in bookmark card no issue - the `willDestroyElement` hook is referencing event handlers that aren't used in the bookmark card - stopped setting `type` in the card payload as it's not used anywhere (possible hangover from when bookmarks were a type of embed card) --- .../addon/components/koenig-card-bookmark.js | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/ghost/admin/lib/koenig-editor/addon/components/koenig-card-bookmark.js b/ghost/admin/lib/koenig-editor/addon/components/koenig-card-bookmark.js index e4cc20a391..207c922b52 100644 --- a/ghost/admin/lib/koenig-editor/addon/components/koenig-card-bookmark.js +++ b/ghost/admin/lib/koenig-editor/addon/components/koenig-card-bookmark.js @@ -65,18 +65,6 @@ export default Component.extend({ this._focusInput(); }, - willDestroyElement() { - this._super(...arguments); - - run.cancel(this._resizeDebounce); - - if (this._iframeMutationObserver) { - this._iframeMutationObserver.disconnect(); - } - - window.removeEventListener('resize', this._windowResizeHandler); - }, - actions: { onDeselect() { if (this.payload.url && !this.payload.metadata && !this.hasError) { @@ -162,7 +150,6 @@ export default Component.extend({ set(this.payload, 'linkOnError', undefined); set(this.payload, 'metadata', response.metadata); - set(this.payload, 'type', response.type); this.saveCard(this.payload, false); } catch (err) { if (this.payload.linkOnError) {