Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Added browser tests for reset password (#21893)

Browse source 
Closes
https://linear.app/ghost/issue/ENG-1856/add-e2e-browser-test-for-password-reset

- Added browser tests for reset password for both cases: 2FA enabled and
disabled.
This commit is contained in:
Princi Vershwal 2024-12-16 23:35:04 +05:30 • committed by GitHub
parent 59b6e92497
commit 485f52df80
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 92 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ghost/admin/app/templates/reset.hbs
View file

@ -11,6 +11,7 @@
<input
type="password"
name="newPassword"
data-test-nav="newPassword"
placeholder="New password"
aria-label="New password"
class="gh-input password reset-password"
@ -28,6 +29,7 @@
name="ne2Password"
placeholder="Confirm new password"
aria-label="Confirm new password"
data-test-nav="newPassword2"
class="gh-input password reset-password"
autocorrect="off"
value={{this.ne2Password}}

90
ghost/core/test/e2e-browser/admin/reset-password.spec.js Normal file
View file

@ -0,0 +1,90 @@
const {expect} = require('@playwright/test');
const test = require('../fixtures/ghost-test');
const DataGenerator = require('../../utils/fixtures/data-generator');
const passwordReset = require('../../../core/server/services/auth/passwordreset');
const api = require('../../../core/server/api/endpoints/index');
test.describe('Admin', () => {
test.describe('Reset Password', () => {
test('Admin can reset password', async ({sharedPage}) => {
// Logout
const context = await sharedPage.context();
await context.clearCookies();
await sharedPage.goto('/ghost');
// Add owner user data from usual fixture
const ownerUser = DataGenerator.Content.users.find(user => user.id === '1');
await sharedPage.locator('#identification').fill(ownerUser.email);
await sharedPage.getByRole('button', {name: 'Forgot?'}).click();
await expect(sharedPage.locator(`text=An email with password reset instructions has been sent.`)).toBeVisible();
const {resetToken} = await passwordReset.generateToken(ownerUser.email, api.settings);
//Reset Password
await sharedPage.goto(`/ghost/reset/${resetToken}/`);
await expect(sharedPage.locator(`text=Reset your password.`)).toBeVisible();
await sharedPage.locator('[data-test-nav="newPassword"]').fill('HiHello@123..');
await sharedPage.locator('[data-test-nav="newPassword2"]').fill('HiHello@123..');
await sharedPage.getByRole('button', {name: 'Save new password'}).click();
await sharedPage.waitForLoadState('networkidle');
await expect(sharedPage).toHaveURL(/\/ghost\/#\/dashboard/);
});
test.describe('2FA Reset Password', () => {
test('Admin can reset password with 2FA enabled', async ({sharedPage}) => {
// Navigate to settings
await sharedPage.goto('/ghost');
await sharedPage.locator('[data-test-nav="settings"]').click();
await sharedPage.waitForLoadState('networkidle');
// Make an API call to get settings
const adminUrl = new URL(sharedPage.url()).origin + '/ghost';
const settingsResponse = await sharedPage.request.get(`${adminUrl}/api/admin/settings/`);
const settingsData = await settingsResponse.json();
// Add staff2fa flag to labs settings
const settings = settingsData.settings;
const labsSetting = settings.find(s => s.key === 'labs');
const labsValue = JSON.parse(labsSetting.value);
labsValue.staff2fa = true;
labsSetting.value = JSON.stringify(labsValue);
// Update settings
await sharedPage.request.put(`${adminUrl}/api/admin/settings/`, {
data: {
settings
}
});
// Logout
const context = await sharedPage.context();
await context.clearCookies();
await sharedPage.goto('/ghost');
// Add owner user data from usual fixture
const ownerUser = DataGenerator.Content.users.find(user => user.id === '1');
await sharedPage.locator('#identification').fill(ownerUser.email);
await sharedPage.getByRole('button', {name: 'Forgot?'}).click();
await expect(sharedPage.locator(`text=An email with password reset instructions has been sent.`)).toBeVisible();
const {resetToken} = await passwordReset.generateToken(ownerUser.email, api.settings);
//Reset Password
await sharedPage.goto(`/ghost/reset/${resetToken}/`);
await expect(sharedPage.locator(`text=Reset your password.`)).toBeVisible();
await sharedPage.locator('[data-test-nav="newPassword"]').fill('HiHello@123..');
await sharedPage.locator('[data-test-nav="newPassword2"]').fill('HiHello@123..');
await sharedPage.getByRole('button', {name: 'Save new password'}).click();
await sharedPage.waitForLoadState('networkidle');
await expect(sharedPage).toHaveURL(/\/ghost\/#\/dashboard/);
});
});
});
});