From 45a70a3f4cf0dd7cccbb63d0a7d8444fb04af732 Mon Sep 17 00:00:00 2001 From: "Fabien \"egg\" O'Carroll" Date: Mon, 8 May 2023 11:07:13 -0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fixed=20Member=20signup=20when?= =?UTF-8?q?=20signup=20terms=20are=20null?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We only display the signup checkbox if both the checkbox is required AND we have some terms to display alongside it. However we require the checkbox to be checked, regardless of if it is displayed. This results in the Signup button not working at all if your settings are in this state. --- ghost/portal/src/components/pages/SignupPage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ghost/portal/src/components/pages/SignupPage.js b/ghost/portal/src/components/pages/SignupPage.js index 1115edce23..a54cb1fd0f 100644 --- a/ghost/portal/src/components/pages/SignupPage.js +++ b/ghost/portal/src/components/pages/SignupPage.js @@ -363,7 +363,7 @@ class SignupPage extends React.Component { } getFormErrors(state) { - const checkboxRequired = this.context.site.portal_signup_checkbox_required; + const checkboxRequired = this.context.site.portal_signup_checkbox_required && this.context.site.portal_signup_terms_html; const checkboxError = checkboxRequired && !state.termsCheckboxChecked; return {