Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Fixed duration options for yearly cadence (#18989)

Browse source 
no issue

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at b84f2a0</samp>

This change improves the offer creation modal by filtering the duration
options based on the tier's cadence. This avoids showing irrelevant or
invalid options to the user and simplifies the selection process.
This commit is contained in:
Ronald Langeveld 2023-11-15 16:36:55 +07:00 • committed by GitHub
parent 199baacfd5
commit 44b4b169a9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
apps/admin-x-settings/src/components/settings/growth/offers/AddOfferModal.tsx
View file

@ -74,6 +74,15 @@ const Sidebar: React.FC<SidebarProps> = ({tierOptions,
handleNameInput,
handleTextAreaInput,
amountOptions}) => {
const getFilteredDurationOptions = () => {
// Check if the selected tier's cadence is 'yearly'
if (selectedTier?.label?.includes('Yearly')) {
// Filter out 'repeating' from duration options
return durationOptions.filter(option => option.value !== 'repeating');
}
return durationOptions;
};
const filteredDurationOptions = getFilteredDurationOptions();
return (
<div className='pt-7'>
<Form>
@ -124,8 +133,8 @@ const Sidebar: React.FC<SidebarProps> = ({tierOptions,
</div>
</div>
<Select
options={durationOptions}
selectedOption={overrides.duration === 'once' ? durationOptions[0] : overrides.duration === 'repeating' ? durationOptions[1] : durationOptions[2]}
options={filteredDurationOptions}
selectedOption={filteredDurationOptions.find(option => option.value === overrides.duration)}
title='Duration'
onSelect={e => handleDurationChange(e?.value || '')}
/>