diff --git a/core/server/services/slack.js b/core/server/services/slack.js index 7413eaf8b8..277edb7beb 100644 --- a/core/server/services/slack.js +++ b/core/server/services/slack.js @@ -45,7 +45,7 @@ function ping(post) { if (slackSettings && slackSettings.url && slackSettings.url !== '') { slackSettings.username = slackSettings.username ? slackSettings.username : 'Ghost'; // Only ping when not a page - if (post.page) { + if (post.type === 'page') { return; } diff --git a/core/server/services/xmlrpc.js b/core/server/services/xmlrpc.js index d8d5220418..b46b4bc795 100644 --- a/core/server/services/xmlrpc.js +++ b/core/server/services/xmlrpc.js @@ -27,7 +27,7 @@ function ping(post) { title = post.title, url = urlService.getUrlByResourceId(post.id, {absolute: true}); - if (post.page || config.isPrivacyDisabled('useRpcPing') || settingsCache.get('is_private')) { + if (post.type === 'page' || config.isPrivacyDisabled('useRpcPing') || settingsCache.get('is_private')) { return; } diff --git a/core/test/unit/services/slack_spec.js b/core/test/unit/services/slack_spec.js index 45f10482de..5db5dd859a 100644 --- a/core/test/unit/services/slack_spec.js +++ b/core/test/unit/services/slack_spec.js @@ -192,7 +192,7 @@ describe('Slack', function () { }); it('does not make a request if post is a page', function () { - const post = testUtils.DataGenerator.forKnex.createPost({page: true}); + const post = testUtils.DataGenerator.forKnex.createPost({type: 'page'}); isPostStub.returns(true); settingsCacheStub.withArgs('slack').returns(slackObjWithUrl);