Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-03-11 02:12:21 -05:00
Code Issues Activity

Added notice of upcoming removal of AMP (#19178)

Browse source 
Google AMP is on the way out. In Ghost 5.0 we changed the integration's
default state to be `disabled`, and we have planned to remove it
completely in Ghost 6.0 for a while — but we haven't shared this
anywhere.

@gergelyorosz bumped into this today:
https://twitter.com/GergelyOrosz/status/1729778093777100973

This PR is to start communicating our intent to remove AMP in the next
major release of Ghost, by adding inline messaging to the integration
settings in Ghost Admin
This commit is contained in:
John O'Nolan 2023-11-29 11:22:33 -04:00 • committed by GitHub
parent e33fe08469
commit 440c804213
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/admin-x-settings/src/components/settings/advanced/Integrations.tsx
View file

@ -109,7 +109,7 @@ const BuiltInIntegrations: React.FC = () => {
openModal('integrations/amp');
}}
active={ampEnabled}
detail='Google Accelerated Mobile Pages'
detail='Google AMP will be removed in Ghost 6.0'
icon={<AmpIcon className='h-8 w-8' />}
title='AMP' />

2
apps/admin-x-settings/src/components/settings/advanced/integrations/AmpModal.tsx
View file

@ -62,7 +62,7 @@ const AmpModal = NiceModal.create(() => {
<Toggle
checked={enabled}
direction='rtl'
hint={<>Enable <a className='text-green' href="https://amp.dev" rel="noopener noreferrer" target='_blank'>Google Accelerated Mobile Pages</a> for your posts</>}
hint={<>Google AMP is <a className='text-green' href="https://en.m.wikipedia.org/wiki/Accelerated_Mobile_Pages" rel="noopener noreferrer" target='_blank'>being retired</a> — this feature will be removed in Ghost 6.0</>}
label='Enable AMP'
onChange={(e) => {
setEnabled(e.target.checked);