Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-03 23:00:14 -05:00
Code Issues Activity

Cleaned up fix for 500 errors on invalid Stripe subscription webhooks

Browse source 
no refs

- moves up check for invalid subscription before making any DB requests to fail fast
This commit is contained in:
Rishabh 2021-12-01 20:26:33 +05:30
parent e83c9e38a7
commit 43642216c8
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ghost/members-api/lib/services/stripe-webhook.js
View file

@ -138,15 +138,17 @@ module.exports = class StripeWebhookService {
}
async subscriptionEvent(subscription) {
const member = await this._memberRepository.get({
customer_id: subscription.customer
});
const subscriptionPriceData = _.get(subscription, 'items.data');
if (!subscriptionPriceData || subscriptionPriceData.length !== 1) {
throw new errors.BadRequestError({
message: 'Subscription should have exactly 1 price item'
});
}
const member = await this._memberRepository.get({
customer_id: subscription.customer
});
if (member) {
await this._memberRepository.linkSubscription({
id: member.id,