Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

Added error handling for product details page

Browse source 
refs https://github.com/TryGhost/Team/issues/678

Product name is a mandatory field for a custom product, this change adds error handling on save and custom error message if product is attempted to save without name.
This commit is contained in:
Rishabh 2021-05-10 19:18:30 +05:30
parent 76319c2717
commit 42463e4fdd
3 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ghost/admin/app/controllers/settings/product.js
View file

@ -160,6 +160,10 @@ export default class ProductController extends Controller {
@task({restartable: true}) @task({restartable: true})
*saveTask() { *saveTask() {
this.send('validatePaidSignupRedirect'); this.send('validatePaidSignupRedirect');
this.product.validate();
if (this.product.get('errors').length !== 0) {
return;
}
if (this.settings.get('errors').length !== 0) { if (this.settings.get('errors').length !== 0) {
return; return;
} }

4
ghost/admin/app/templates/settings/product.hbs
View file

@ -29,10 +29,10 @@
<h4 class="gh-main-section-header small bn">Product details</h4> <h4 class="gh-main-section-header small bn">Product details</h4>
<div class="gh-main-section-content grey gh-product-details-form"> <div class="gh-main-section-content grey gh-product-details-form">
<div class="gh-product-details-fields"> <div class="gh-product-details-fields">
<GhFormGroup @property="name" @classNames="max-width"> <GhFormGroup @errors={{this.product.errors}} @hasValidated={{this.product.hasValidated}} @property="name" @classNames="max-width">
<label for="product-name">Product name</label> <label for="product-name">Product name</label>
<GhTextInput data-test-input="product-name" @id="product-name" @value={{product.name}}/> <GhTextInput data-test-input="product-name" @id="product-name" @value={{product.name}}/>
<GhErrorMessage @property="name" /> <GhErrorMessage @errors={{this.product.errors}} @property="name" />
</GhFormGroup> </GhFormGroup>
<GhFormGroup @property="description" @classNames="max-width"> <GhFormGroup @property="description" @classNames="max-width">

4
ghost/admin/app/validators/product.js
View file

@ -5,6 +5,10 @@ export default BaseValidator.create({
properties: ['name'], properties: ['name'],
name(model) { name(model) {
if (!model.name) {
model.errors.add('name', 'Please enter Name.');
this.invalidate();
}
if (!validator.isLength(model.name || '', 0, 191)) { if (!validator.isLength(model.name || '', 0, 191)) {
model.errors.add('name', 'Name cannot be longer than 191 characters.'); model.errors.add('name', 'Name cannot be longer than 191 characters.');
this.invalidate(); this.invalidate();