Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Wired up stripe-connect module to settings API

Browse source 
no-issue

Uses the members service to parse a stripe_connect_integration_token
setting and set the stripe_connect_integration based on that.

This change includes ignoring the stripe_connect_integration{,_token}
settings, as the token is never saved, and the integration can only be
set by using the token.
This commit is contained in:
Fabien O'Carroll 2020-05-28 12:40:50 +02:00 • committed by Fabien 'egg' O'Carroll
parent 95acbbad93
commit 413aa06ca5
1 changed files with 24 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
core/server/api/canary/settings.js
View file

@ -3,8 +3,9 @@ const _ = require('lodash');
const models = require('../../models'); const models = require('../../models');
const routing = require('../../../frontend/services/routing'); const routing = require('../../../frontend/services/routing');
const {i18n} = require('../../lib/common'); const {i18n} = require('../../lib/common');
const {NoPermissionError, NotFoundError} = require('@tryghost/errors'); const {BadRequestError, NoPermissionError, NotFoundError} = require('@tryghost/errors');
const settingsCache = require('../../services/settings/cache'); const settingsCache = require('../../services/settings/cache');
const membersService = require('../../services/members');
const SETTINGS_BLACKLIST = [ const SETTINGS_BLACKLIST = [
'members_public_key', 'members_public_key',
@ -101,7 +102,13 @@ module.exports = {
} }
}, },
async query(frame) { async query(frame) {
const settings = frame.data.settings; const stripeConnectIntegrationToken = frame.data.settings.find(setting => setting.key === 'stripe_connect_integration_token');
// The `stripe_connect_integration_token` "setting" is only used to set the `stripe_connect_integration` setting.
// The `stripe_connect_integration` setting is not allowed to be set directly.
const settings = frame.data.settings.filter((setting) => {
return !['stripe_connect_integration', 'stripe_connect_integration_token'].includes(setting.key);
});
const getSetting = setting => settingsCache.get(setting.key, {resolve: false}); const getSetting = setting => settingsCache.get(setting.key, {resolve: false});
@ -124,6 +131,21 @@ module.exports = {
} }
} }
if (stripeConnectIntegrationToken) {
const getSessionProp = prop => frame.original.session[prop];
try {
const data = await membersService.stripeConnect.getStripeConnectTokenData(stripeConnectIntegrationToken.value, getSessionProp);
settings.push({
key: 'stripe_connect_integration',
value: JSON.stringify(data)
});
} catch (err) {
throw new BadRequestError({
message: 'The Stripe Connect token could not be parsed.'
});
}
}
return models.Settings.edit(settings, frame.options); return models.Settings.edit(settings, frame.options);
} }
}, },