Merge pull request #5772 from kevinansfield/minor-tag-input-updates

Don't show selectize dropdown when input field is blank

core/client/app/components/gh-search-input.js

@@ -124,23 +124,6 @@ export default Ember.Component.extend({
 
         onBlur: function () {
             this._resetKeymasterScope();
-        },
-
-        // hacky method of disabling the dropdown until a user has typed something
-        // TODO: move into a selectize plugin
-        onInit: function () {
-            var selectize = this.get('_selectize');
-            selectize.on('dropdown_open', function () {
-                if (Ember.isBlank(selectize.$control_input.val())) {
-                    selectize.close();
-                }
-            });
-        },
-
-        onUpdateFilter: function (filter) {
-            if (Ember.isBlank(filter)) {
-                this.get('_selectize').close();
-            }
         }
     }
 

core/client/app/components/gh-selectize.js

@@ -3,6 +3,26 @@ import EmberSelectizeComponent from 'ember-cli-selectize/components/ember-select
 
 export default EmberSelectizeComponent.extend({
 
+    _dontOpenWhenBlank: Ember.on('didInsertElement', function () {
+        var openOnFocus = this.get('openOnFocus');
+
+        if (!openOnFocus) {
+            Ember.run.next(this, function () {
+                var selectize = this._selectize;
+                selectize.on('dropdown_open', function () {
+                    if (Ember.isBlank(selectize.$control_input.val())) {
+                        selectize.close();
+                    }
+                });
+                selectize.on('type', function (filter) {
+                    if (Ember.isBlank(filter)) {
+                        selectize.close();
+                    }
+                });
+            });
+        }
+    }),
+
     /**
     * Event callback that is triggered when user creates a tag
     * - modified to pass the caret position to the action

core/client/app/templates/components/gh-search-input.hbs

@@ -8,9 +8,7 @@
     optionGroupPath="content.category"
     openOnFocus=false
     maxItems="1"
-    on-init="onInit"
     on-focus="onFocus"
     on-blur="onBlur"
-    select-item="openSelected"
+    select-item="openSelected"}}
-    update-filter="onUpdateFilter"}}
 <button class="gh-nav-search-button" {{action "focusInput"}}><i class="icon-search"></i><span class="sr-only">Search</span></button>

core/client/app/templates/post-settings-menu.hbs

@@ -43,6 +43,7 @@
                     content=availableTags
                     optionValuePath="content.uuid"
                     optionLabelPath="content.name"
+                    openOnFocus=false
                     create-item="addTag"
                     remove-item="removeTag"}}
             </div>