Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

Enabled error for "no-shadow" eslint rule

Browse source 
refs 635580f291

- Changed `no-shadow` eslint rule from `warn` to `error` so we don't re-introduce shadowed variables in the future. Should be removed once this change is introduced in a base plugin
- Referenced commit is a chain of commits which fixed the warning which this rule was producing previously
This commit is contained in:
Naz 2020-10-27 11:27:37 +13:00
parent 983e2c4e0e
commit 3eeb899e65
2 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.eslintrc.json
View file

@ -10,6 +10,8 @@
"plugin:ghost/node" "plugin:ghost/node"
], ],
"rules": { "rules": {
// TODO: remove this rule once it's turned into "error" in the base plugin
"no-shadow": "error",
"no-var": "error", "no-var": "error",
"one-var": [2, "never"] "one-var": [2, "never"]
} }

3
test/.eslintrc.json
View file

@ -12,6 +12,9 @@
"plugin:ghost/test" "plugin:ghost/test"
], ],
"rules": { "rules": {
// TODO: remove this rule once it's turned into "error" in the base plugin
"no-shadow": "error",
// these rules were were not previously enforced in our custom rules, // these rules were were not previously enforced in our custom rules,
// they're turned off here because they _are_ enforced in our plugin. // they're turned off here because they _are_ enforced in our plugin.
// TODO: remove these custom rules and fix the problems in test files where appropriate // TODO: remove these custom rules and fix the problems in test files where appropriate