Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Refactored row -> entity mapping

Browse source
This commit is contained in:
Fabien "egg" O'Carroll 2023-11-29 10:11:59 +00:00
parent 323e102def
commit 3c2939c8a9
1 changed files with 20 additions and 44 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

64
ghost/ghost/src/db/knex/snippets.repository.ts
View file

@ -12,6 +12,23 @@ export class KnexSnippetsRepository implements SnippetsRepository {
readonly table = 'snippets';
private mapRowToEntity(row: any): Snippet | null {
try {
const snippet = Snippet.create({
id: row.id,
name: row.name,
lexical: row.lexical,
mobiledoc: row.mobiledoc,
createdAt: new Date(row.created_at),
updatedAt: row.updated_at ? new Date(row.updated_at) : null
});
return snippet;
} catch (err) {
// TODO: Sentry logging
return null;
}
}
async save(entity: Snippet): Promise<void> {
const rows = await this.knex(this.table)
.where('id', entity.id.toHexString())
@ -50,22 +67,7 @@ export class KnexSnippetsRepository implements SnippetsRepository {
}
assert(rows.length === 1, 'Found two rows with the same id');
const row = rows[0];
try {
const snippet = Snippet.create({
id: row.id,
name: row.name,
lexical: row.lexical,
mobiledoc: row.mobiledoc,
createdAt: new Date(row.created_at),
updatedAt: row.updated_at ? new Date(row.updated_at) : null
});
return snippet;
} catch (err) {
// TODO: Sentry logging
return null;
}
return this.mapRowToEntity(rows[0]);
}
async getAll(
@ -84,20 +86,7 @@ export class KnexSnippetsRepository implements SnippetsRepository {
}
const rows = await query.select();
const snippets = rows.reduce((memo, row) => {
let entity;
try {
entity = Snippet.create({
id: row.id,
name: row.name,
lexical: row.lexical,
mobiledoc: row.mobiledoc,
createdAt: new Date(row.created_at),
updatedAt: row.updated_at ? new Date(row.updated_at) : null
});
} catch (err) {
// TODO: Sentry logging
entity = null;
}
const entity = this.mapRowToEntity(row);
if (!entity) {
return memo;
}
@ -126,20 +115,7 @@ export class KnexSnippetsRepository implements SnippetsRepository {
}
const rows = await query.select();
const snippets = rows.reduce((memo, row) => {
let entity;
try {
entity = Snippet.create({
id: row.id,
name: row.name,
lexical: row.lexical,
mobiledoc: row.mobiledoc,
createdAt: new Date(row.created_at),
updatedAt: row.updated_at ? new Date(row.updated_at) : null
});
} catch (err) {
// TODO: Sentry logging
entity = null;
}
const entity = this.mapRowToEntity(row);
if (!entity) {
return memo;
}