Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-10 23:36:14 -05:00
Code Issues Activity

Added Playwright "Update published post" test (#15958)

Browse source 
refs https://github.com/TryGhost/Team/issues/2371

- tests modifying the content of a published post
- extracted publish flow into a `publishPost` function that returns a new browser page object with the newly created post loaded
This commit is contained in:
Kevin Ansfield 2022-12-07 14:13:23 +00:00 • committed by GitHub
parent 5bd82bc6d7
commit 3bd9e2ecfe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 86 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

115
ghost/core/test/e2e-browser/admin/publishing.spec.js
View file

@ -3,8 +3,11 @@ const {expect, test} = require('@playwright/test');
/**
* Start a post draft with a filled in title and body. We can consider to move this to utils later.
* @param {import('@playwright/test').Page} page
* @param {Object} options
* @param {String} [options.title]
* @param {String} [options.body]
*/
const createPost = async (page) => {
const createPost = async (page, {title = 'Hello world', body = 'This is my post body.'} = {}) => {
await page.locator('.gh-nav a[href="#/posts/"]').click();
// Create a new post
@ -12,14 +15,13 @@ const createPost = async (page) => {
// Fill in the post title
await page.locator('[data-test-editor-title-input]').click();
await page.locator('[data-test-editor-title-input]').fill('Hello world');
await page.locator('[data-test-editor-title-input]').fill(title);
// Continue to the body by pressing enter
await page.keyboard.press('Enter');
// We need to check focused because otherwise it will start typing too soon and we'll lose a part of the text
await expect(page.locator('.koenig-editor [contenteditable="true"]')).toBeFocused();
await page.keyboard.type('This is my post body.');
await page.waitForTimeout(100); // allow new->draft switch to occur fully, without this some initial typing events can be missed
await page.keyboard.type(body);
};
/**
@ -29,37 +31,92 @@ const openPublishFlow = async (page) => {
await page.locator('[data-test-button="publish-flow"]').click();
};
/**
* @param {import('@playwright/test').Page} page
*/
const closePublishFlow = async (page) => {
await page.locator('[data-test-modal="publish-flow"] [data-test-button="back-to-editor"]').click();
};
/**
* @typedef {Object} PublishOptions
* @property {'publish'|'publish+send'|'send'} [type]
* @property {String} [recipientFilter]
* @property {String} [newsletter]
* @property {String} [date]
*/
/**
* Open and complete publish flow, filling in all necessary fields based on publish options
* @param {import('@playwright/test').Page} page
* @param {PublishOptions} options
*/
const publishPost = async (page, {type = 'publish'} = {}) => {
await openPublishFlow(page);
// set the publish type
await page.locator('[data-test-setting="publish-type"] > button').click();
await page.locator(`[data-test-publish-type="${type}"]`).setChecked(true);
// TODO: set other publish options
// continue to confirmation step
await page.locator('[data-test-modal="publish-flow"] [data-test-button="continue"]').click();
// TODO: assert publish flow has expected confirmation details
// (we need force because the button is animating)
await page.locator('[data-test-modal="publish-flow"] [data-test-button="confirm-publish"]').click({force: true});
// TODO: assert publish flow has expected completion details
// open the published post in a new tab
const [frontendPage] = await Promise.all([
page.waitForEvent('popup'),
page.locator('[data-test-complete-bookmark]').click()
]);
await closePublishFlow(page);
return frontendPage;
};
test.describe('Publishing', () => {
test.describe('Publish post', () => {
test('Post should only be available on web', async ({page}) => {
await page.goto('/ghost');
await createPost(page);
// Publish the post
await openPublishFlow(page);
// Check if publish only
await page.locator('[data-test-setting="publish-type"] > button').click();
// We can choose publish, publish+send or send here, but we need 'publish' only here.
await page.locator('[data-test-publish-type="publish"]').setChecked(true);
// Continue
await page.locator('[data-test-button="continue"]').click();
// Confirm publishing
// (we need force because the button is animating)
await page.locator('[data-test-button="confirm-publish"]').click({force: true});
// Open the published post in a new tab
const [page1] = await Promise.all([
page.waitForEvent('popup'),
page.locator('[data-test-complete-bookmark]').click()
]);
const frontendPage = await publishPost(page);
// Check if 'This is my post body.' is present on page1
await expect(page1.locator('.gh-canvas .article-title')).toHaveText('Hello world');
await expect(page1.locator('.gh-content.gh-canvas > p')).toHaveText('This is my post body.');
await expect(frontendPage.locator('.gh-canvas .article-title')).toHaveText('Hello world');
await expect(frontendPage.locator('.gh-content.gh-canvas > p')).toHaveText('This is my post body.');
});
});
test.describe('Update post', () => {
test('Can update a published post', async ({page: adminPage, browser}) => {
await adminPage.goto('/ghost');
await createPost(adminPage, {title: 'Testing publish update', body: 'This is the initial published text.'});
const frontendPage = await publishPost(adminPage);
const frontendBody = frontendPage.getByRole('main');
// check front-end post has the initial body text
await expect(frontendBody).toContainText('This is the initial published text.');
// add some extra text to the post
await adminPage.locator('[data-kg="editor"]').click();
await adminPage.keyboard.press('Enter');
await adminPage.keyboard.type('This is some updated text.');
// save
await adminPage.locator('[data-test-button="publish-save"]').click();
// check front-end has new text after reloading
await frontendPage.waitForTimeout(100); // let save go through
await frontendPage.reload();
await expect(frontendBody).toContainText('This is some updated text.');
});
});
});