Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-06 22:40:14 -05:00
Code Issues Activity

Small performance tweak for Posts ordering.

Browse source 
* Move publishedAtCompare to standalone function in closure scope
  (allows better browser optimizations).
* Avoid getting the same field (published_at) more than once.
This commit is contained in:
Robert Jackson 2014-08-02 11:15:55 -04:00
parent d35598457b
commit 3bd938a7eb
No known key found for this signature in database
GPG key ID: B3D10EF8171F7219
1 changed files with 21 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
core/client/controllers/posts.js
View file

@ -1,5 +1,25 @@
import PaginationControllerMixin from 'ghost/mixins/pagination-controller'; import PaginationControllerMixin from 'ghost/mixins/pagination-controller';
function publishedAtCompare(item1, item2) {
var published1 = item1.get('published_at'),
published2 = item2.get('published_at');
if (!published1 && !published2) {
return 0;
}
if (!published1 && published2) {
return -1;
}
if (!published2 && published1) {
return 1;
}
return Ember.compare(published1.valueOf(), published2.valueOf());
}
var PostsController = Ember.ArrayController.extend(PaginationControllerMixin, { var PostsController = Ember.ArrayController.extend(PaginationControllerMixin, {
// this will cause the list to re-sort when any of these properties change on any of the models // this will cause the list to re-sort when any of these properties change on any of the models
sortProperties: ['status', 'published_at', 'updated_at'], sortProperties: ['status', 'published_at', 'updated_at'],
@ -15,25 +35,6 @@ var PostsController = Ember.ArrayController.extend(PaginationControllerMixin, {
// published_at: DESC // published_at: DESC
// updated_at: DESC // updated_at: DESC
orderBy: function (item1, item2) { orderBy: function (item1, item2) {
function publishedAtCompare() {
var published1 = item1.get('published_at'),
published2 = item2.get('published_at');
if (!published1 && !published2) {
return 0;
}
if (!published1 && published2) {
return -1;
}
if (!published2 && published1) {
return 1;
}
return Ember.compare(item1.get('published_at').valueOf(), item2.get('published_at').valueOf());
}
var updated1 = item1.get('updated_at'), var updated1 = item1.get('updated_at'),
updated2 = item2.get('updated_at'), updated2 = item2.get('updated_at'),
statusResult, statusResult,
@ -52,7 +53,7 @@ var PostsController = Ember.ArrayController.extend(PaginationControllerMixin, {
statusResult = Ember.compare(item1.get('status'), item2.get('status')); statusResult = Ember.compare(item1.get('status'), item2.get('status'));
updatedAtResult = Ember.compare(updated1.valueOf(), updated2.valueOf()); updatedAtResult = Ember.compare(updated1.valueOf(), updated2.valueOf());
publishedAtResult = publishedAtCompare(); publishedAtResult = publishedAtCompare(item1, item2);
if (statusResult === 0) { if (statusResult === 0) {
if (publishedAtResult === 0) { if (publishedAtResult === 0) {