Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-02-24 23:48:13 -05:00
Code Issues Activity

Removed @classic decorator from member route

Browse source 
no issue

- there was no need for the decorator as the class is up to date with Octane idioms after swapping `init()` for `constructor()`
- added a comment about the need for `member.get('id')`
This commit is contained in:
Kevin Ansfield 2021-08-31 09:37:44 +01:00
parent 0a698ec41f
commit 3bc226bef0
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ghost/admin/app/routes/member.js
View file

@ -1,16 +1,14 @@
import AuthenticatedRoute from 'ghost-admin/routes/authenticated'; import AuthenticatedRoute from 'ghost-admin/routes/authenticated';
import classic from 'ember-classic-decorator';
import {action} from '@ember/object'; import {action} from '@ember/object';
import {inject as service} from '@ember/service'; import {inject as service} from '@ember/service';
@classic
export default class MembersRoute extends AuthenticatedRoute { export default class MembersRoute extends AuthenticatedRoute {
@service router; @service router;
_requiresBackgroundRefresh = true; _requiresBackgroundRefresh = true;
init() { constructor() {
super.init(...arguments); super(...arguments);
this.router.on('routeWillChange', (transition) => { this.router.on('routeWillChange', (transition) => {
this.showUnsavedChangesModal(transition); this.showUnsavedChangesModal(transition);
}); });
@ -36,6 +34,8 @@ export default class MembersRoute extends AuthenticatedRoute {
setupController(controller, member) { setupController(controller, member) {
super.setupController(...arguments); super.setupController(...arguments);
if (this._requiresBackgroundRefresh) { if (this._requiresBackgroundRefresh) {
// `member` is passed directly in `<LinkTo>` so it can be a proxy
// object used by the sparse list requiring the use of .get()
controller.fetchMemberTask.perform(member.get('id')); controller.fetchMemberTask.perform(member.get('id'));
} }
} }