Fixed default sender address when email is managed (#19186)

fixes GRO-74

- uses the calculated setting "default_email_address" as first fallback, if there is no sender email for the newsletter

ghost/admin/app/components/editor/modals/preview/email.hbs

@@ -13,7 +13,7 @@
                                 @triggerComponent={{component "gh-power-select/trigger"}}
                                 @triggerClass="gh-preview-newsletter-trigger"
                                 @dropdownClass="gh-publish-newsletter-dropdown gh-preview-newsletter-dropdown"
-                                @extra={{concat "<" (full-email-address (or this.newsletter.senderEmail "noreply")) ">"}}
+                                @extra={{concat "<" (full-email-address (or this.newsletter.senderEmail this.settings.defaultEmailAddress "noreply")) ">"}}
                                 @selectedItemComponent={{component "editor/modals/preview/selected-newsletter-label"}}
                                 data-test-email-preview-newsletter-select
                                 as |option|
@@ -23,7 +23,7 @@
                         {{else}}
                             <p class="gh-preview-newsletter-name">{{this.newsletter.name}} <span
                                 class="gh-preview-email-address">&lt;{{full-email-address
-                                (or this.newsletter.senderEmail "noreply")}}&gt;</span></p>
+                                (or this.newsletter.senderEmail this.settings.defaultEmailAddress "noeply")}}&gt;</span></p>
                         {{/if}}
                     </div>
                     <div class="gh-email-preview-newsletter-select" data-test-email-preview-segment-select-section>

ghost/admin/app/components/modals/email-preview.hbs

@@ -20,7 +20,7 @@
                 <div class="gh-pe-mobile-screen">
                     <div class="gh-pe-emailclient-sender">
                         <p>
-                            <span class="strong">{{or this.newsletter.senderName this.settings.title}}</span> &lt;{{full-email-address (or this.newsletter.senderEmail "noreply")}}&gt;
+                            <span class="strong">{{or this.newsletter.senderName this.settings.title}}</span> &lt;{{full-email-address (or this.newsletter.senderEmail this.settings.defaultEmailAddress "noreply")}}&gt;
                         </p>
                         <p><span class="dark">To:</span> Jamie Larson &lt;jamie@example.com&gt;</p>
                     </div>
@@ -35,7 +35,7 @@
             <div class="gh-pe-emailclient-mockup">
                 <div class="gh-pe-emailclient-sender">
                     <p>
-                        <span class="strong">{{or this.newsletter.senderName this.settings.title}}</span> &lt;{{full-email-address (or this.newsletter.senderEmail "noreply")}}&gt;
+                        <span class="strong">{{or this.newsletter.senderName this.settings.title}}</span> &lt;{{full-email-address (or this.newsletter.senderEmail this.settings.defaultEmailAddress "noreply")}}&gt;
                     </p>
                     <p><span class="dark">To:</span> Jamie Larson &lt;jamie@example.com&gt;</p>
                 </div>

ghost/admin/app/models/setting.js

@@ -110,6 +110,12 @@ export default Model.extend(ValidationEngine, {
      */
     recommendationsEnabled: attr('boolean'),
 
+    /**
+     * Newsletter emails
+     */
+    defaultEmailAddress: attr('string'),
+    supportEmailAddress: attr('string'),
+
     // HACK - not a real model attribute but a workaround for Ember Data not
     //        exposing meta from save responses
     _meta: attr()