Infrastructure/ghost
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2025-01-20 22:42:53 -05:00
Code Issues Activity

Fix broken @last for foreach with limit

Browse source 
refs #6205
This commit is contained in:
Fabian Becker 2015-12-18 15:06:37 +01:00
parent 48bc031ac1
commit 3b235b9acb
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/server/helpers/foreach.js
View file

@ -18,7 +18,7 @@ foreach = function (context, options) {
inverse = options.inverse, inverse = options.inverse,
columns = options.hash.columns, columns = options.hash.columns,
length = _.size(context), length = _.size(context),
limit = options.hash.limit || length, limit = parseInt(options.hash.limit, 10) || length,
output = '', output = '',
data, data,
contextPath; contextPath;
@ -63,7 +63,7 @@ foreach = function (context, options) {
_.each(context, function (item, key) { _.each(context, function (item, key) {
if (count <= limit) { if (count <= limit) {
execIteration(key, count - 1, count === length); execIteration(key, count - 1, count === limit);
} }
count += 1; count += 1;
}); });

8
core/test/unit/server_helpers/foreach_spec.js
View file

@ -355,6 +355,14 @@ describe('{{#foreach}} helper', function () {
shouldCompileToExpected(templateString, objectHash2, expected); shouldCompileToExpected(templateString, objectHash2, expected);
}); });
it('@last in foreach with limit', function () {
var templateString = '{{#foreach goodbyes limit="2"}}{{#if @last}}{{text}}! {{/if}}{{/foreach}}cruel {{world}}!',
expected = 'Goodbye! cruel world!';
shouldCompileToExpected(templateString, arrayHash2, expected);
shouldCompileToExpected(templateString, objectHash2, expected);
});
it('foreach with limit 1', function () { it('foreach with limit 1', function () {
var templateString = '<ul>{{#foreach posts limit="1"}}<li>{{title}}</li>{{else}}not this{{/foreach}}</ul>', var templateString = '<ul>{{#foreach posts limit="1"}}<li>{{title}}</li>{{else}}not this{{/foreach}}</ul>',
expected = '<ul><li>first</li></ul>'; expected = '<ul><li>first</li></ul>';